yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-04-17 12:41:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Breakpad Linux dumper: Don't be silly about global functions.

Browse source 
Yes, classes are useful. But that doesn't mean that every function has
to gratuitously become a member function. The Google C++ Style Guide
does not require this silliness, since the function is in the
google_breakpad namespace anyway.

a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@519 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2010-02-09 17:13:17 +00:00
parent c50e7c604c
commit 952f3c7b73
3 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/common/linux/dump_symbols.cc
View file

@ -355,8 +355,7 @@ std::string BaseFileName(const std::string &filename) {
namespace google_breakpad {
bool DumpSymbols::WriteSymbolFile(const std::string &obj_file,
FILE *sym_file) {
bool WriteSymbolFile(const std::string &obj_file, FILE *sym_file) {
int obj_fd = open(obj_file.c_str(), O_RDONLY);
if (obj_fd < 0) {
fprintf(stderr, "Failed to open ELF file '%s': %s\n",

13
src/common/linux/dump_symbols.h
View file

@ -1,4 +1,6 @@
// Copyright (c) 2006, Google Inc.
// -*- mode: c++ -*-
// Copyright (c) 2010, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@ -38,11 +40,10 @@
namespace google_breakpad {
class DumpSymbols {
public:
bool WriteSymbolFile(const std::string &obj_file,
FILE *sym_file);
};
// Find all the debugging information in OBJ_FILE, an ELF executable
// or shared library, and write it to SYM_FILE in the Breakpad symbol
// file format.
bool WriteSymbolFile(const std::string &obj_file, FILE *sym_file);
} // namespace google_breakpad

7
src/tools/linux/dump_syms/dump_syms.cc
View file

@ -1,4 +1,4 @@
// Copyright (c) 2006, Google Inc.
// Copyright (c) 2010, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@ -36,14 +36,13 @@ using namespace google_breakpad;
int main(int argc, char **argv) {
if (argc != 2) {
fprintf(stderr, "Usage: %s <binary-with-stab-symbol>\n", argv[0]);
fprintf(stderr, "Usage: %s <binary-with-debugging-info>\n", argv[0]);
return 1;
}
const char *binary = argv[1];
DumpSymbols dumper;
if (!dumper.WriteSymbolFile(binary, stdout)) {
if (!WriteSymbolFile(binary, stdout)) {
fprintf(stderr, "Failed to write symbol file.\n");
return 1;
}