yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-08-22 03:51:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Breakpad Linux dumper: Include filename in error messages.

Browse source 
a=jimblandy, r=nealsid


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@562 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2010-03-31 15:32:31 +00:00
parent 608d142aaa
commit a0aca73851
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/common/linux/dump_symbols.cc
View file

@ -169,8 +169,8 @@ static bool LoadDwarf(const string &dwarf_filename,
else if (elf_header->e_ident[EI_DATA] == ELFDATA2MSB) else if (elf_header->e_ident[EI_DATA] == ELFDATA2MSB)
endianness = dwarf2reader::ENDIANNESS_BIG; endianness = dwarf2reader::ENDIANNESS_BIG;
else { else {
fprintf(stderr, "bad data encoding in ELF header: %d\n", fprintf(stderr, "%s: bad data encoding in ELF header: %d\n",
elf_header->e_ident[EI_DATA]); dwarf_filename.c_str(), elf_header->e_ident[EI_DATA]);
return false; return false;
} }
dwarf2reader::ByteReader byte_reader(endianness); dwarf2reader::ByteReader byte_reader(endianness);
@ -368,8 +368,8 @@ static bool LoadSymbols(const std::string &obj_file, ElfW(Ehdr) *elf_header,
if (stabstr_section) { if (stabstr_section) {
found_debug_info_section = true; found_debug_info_section = true;
if (!LoadStabs(stab_section, stabstr_section, module)) if (!LoadStabs(stab_section, stabstr_section, module))
fprintf(stderr, "\".stab\" section found, but failed to load STABS" fprintf(stderr, "%s: \".stab\" section found, but failed to load STABS"
" debugging information\n"); " debugging information\n", obj_file.c_str());
} }
} }
@ -380,8 +380,8 @@ static bool LoadSymbols(const std::string &obj_file, ElfW(Ehdr) *elf_header,
if (dwarf_section) { if (dwarf_section) {
found_debug_info_section = true; found_debug_info_section = true;
if (!LoadDwarf(obj_file, elf_header, module)) if (!LoadDwarf(obj_file, elf_header, module))
fprintf(stderr, "\".debug_info\" section found, but failed to load " fprintf(stderr, "%s: \".debug_info\" section found, but failed to load "
"DWARF debugging information\n"); "DWARF debugging information\n", obj_file.c_str());
} }
// Dwarf Call Frame Information (CFI) is actually independent from // Dwarf Call Frame Information (CFI) is actually independent from
@ -416,8 +416,9 @@ static bool LoadSymbols(const std::string &obj_file, ElfW(Ehdr) *elf_header,
} }
if (!found_debug_info_section) { if (!found_debug_info_section) {
fprintf(stderr, "file contains no debugging information" fprintf(stderr, "%s: file contains no debugging information"
" (no \".stab\" or \".debug_info\" sections)\n"); " (no \".stab\" or \".debug_info\" sections)\n",
obj_file.c_str());
return false; return false;
} }
return true; return true;
@ -558,14 +559,15 @@ bool WriteSymbolFile(const std::string &obj_file, FILE *sym_file) {
unsigned char identifier[16]; unsigned char identifier[16];
google_breakpad::FileID file_id(obj_file.c_str()); google_breakpad::FileID file_id(obj_file.c_str());
if (!file_id.ElfFileIdentifier(identifier)) { if (!file_id.ElfFileIdentifier(identifier)) {
fprintf(stderr, "Unable to generate file identifier\n"); fprintf(stderr, "%s: unable to generate file identifier\n",
obj_file.c_str());
return false; return false;
} }
const char *architecture = ElfArchitecture(elf_header); const char *architecture = ElfArchitecture(elf_header);
if (!architecture) { if (!architecture) {
fprintf(stderr, "Unrecognized ELF machine architecture: %d\n", fprintf(stderr, "%s: unrecognized ELF machine architecture: %d\n",
elf_header->e_machine); obj_file.c_str(), elf_header->e_machine);
return false; return false;
} }