yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-12-23 23:55:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix harmless printf abuse in symupload.

Browse source 
symupload printed -[NSData length], an NSUInteger, using %lu. %lu is proper
to print a "long" as unsigned, but NSUInteger is a typedef for "unsigned int"
when building for 32-bit. This would not have caused any problems, because in
the 32-bit model, both int and long are 32 bits wide. In the 64-bit model,
long is 64 bits wide, but NSUInteger is defiend as "unsigned long", so there
wouldn't have even been a warning in that case.

This addresses the following warning:

symupload.m:137:30:{137:28-137:31}{137:46-137:59}: warning: conversion specifies type 'unsigned long' but the argument has type 'NSUInteger' (aka 'unsigned int') [-Wformat]
Review URL: http://breakpad.appspot.com/313002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@860 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
mark@chromium.org 2011-10-11 17:38:01 +00:00
parent 6669714772
commit a75f1bf9e7
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/tools/mac/symupload/symupload.m
View file

@ -134,7 +134,8 @@ static void Start(Options *options) {
fprintf(stdout, "Send: %s\n", error ? [[error description] UTF8String] : fprintf(stdout, "Send: %s\n", error ? [[error description] UTF8String] :
"No Error"); "No Error");
fprintf(stdout, "Response: %d\n", status); fprintf(stdout, "Response: %d\n", status);
fprintf(stdout, "Result: %lu bytes\n%s\n", [data length], [result UTF8String]); fprintf(stdout, "Result: %lu bytes\n%s\n",
(unsigned long)[data length], [result UTF8String]);
[result release]; [result release];
[ul release]; [ul release];