yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-07-10 06:17:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reducing severity of most commonly logged ERRORS.

Browse source 
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@681 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jessicag.feedback@gmail.com 2010-09-09 21:15:32 +00:00
parent f24c2e1952
commit bb87ebd809
2 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/processor/minidump.cc
View file

@ -1185,11 +1185,12 @@ bool MinidumpMemoryRegion::GetMemoryAtAddressInternal(u_int64_t address,
return false; return false;
} }
// Common failure case
if (address < descriptor_->start_of_memory_range || if (address < descriptor_->start_of_memory_range ||
sizeof(T) > numeric_limits<u_int64_t>::max() - address || sizeof(T) > numeric_limits<u_int64_t>::max() - address ||
address + sizeof(T) > descriptor_->start_of_memory_range + address + sizeof(T) > descriptor_->start_of_memory_range +
descriptor_->memory.data_size) { descriptor_->memory.data_size) {
BPLOG(ERROR) << "MinidumpMemoryRegion request out of range: " << BPLOG(INFO) << "MinidumpMemoryRegion request out of range: " <<
HexString(address) << "+" << sizeof(T) << "/" << HexString(address) << "+" << sizeof(T) << "/" <<
HexString(descriptor_->start_of_memory_range) << "+" << HexString(descriptor_->start_of_memory_range) << "+" <<
HexString(descriptor_->memory.data_size); HexString(descriptor_->memory.data_size);
@ -1839,8 +1840,9 @@ string MinidumpModule::debug_file() const {
} }
} }
BPLOG_IF(ERROR, file.empty()) << "MinidumpModule could not determine " // Relatively common case
"debug_file for " << *name_; BPLOG_IF(INFO, file.empty()) << "MinidumpModule could not determine "
"debug_file for " << *name_;
return file; return file;
} }
@ -1907,8 +1909,9 @@ string MinidumpModule::debug_identifier() const {
// TODO(mmentovai): on the Mac, provide fallbacks as in code_identifier(). // TODO(mmentovai): on the Mac, provide fallbacks as in code_identifier().
BPLOG_IF(ERROR, identifier.empty()) << "MinidumpModule could not determine " // Relatively common case
"debug_identifier for " << *name_; BPLOG_IF(INFO, identifier.empty()) << "MinidumpModule could not determine "
"debug_identifier for " << *name_;
return identifier; return identifier;
} }

6
src/processor/postfix_evaluator-inl.h
View file

@ -162,8 +162,8 @@ bool PostfixEvaluator<ValueType>::EvaluateInternal(
// = for assignment. // = for assignment.
ValueType value; ValueType value;
if (!PopValue(&value)) { if (!PopValue(&value)) {
BPLOG(ERROR) << "Could not PopValue to get value to assign: " << BPLOG(INFO) << "Could not PopValue to get value to assign: " <<
expression; expression;
return false; return false;
} }
@ -299,7 +299,7 @@ bool PostfixEvaluator<ValueType>::PopValue(ValueType *value) {
if (iterator == dictionary_->end()) { if (iterator == dictionary_->end()) {
// The identifier wasn't found in the dictionary. Don't imply any // The identifier wasn't found in the dictionary. Don't imply any
// default value, just fail. // default value, just fail.
BPLOG(ERROR) << "Identifier " << token << " not in dictionary"; BPLOG(INFO) << "Identifier " << token << " not in dictionary";
return false; return false;
} }