yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-03-01 15:38:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a clang warning.

Browse source 
Since explanatoryDialogText returns something that migth be user input, this
looks like a good change anyhow.

../../breakpad/src/client/mac/sender/crash_report_sender.m:269:38:
error: format string is not a string literal (potentially insecure)
    [-Werror,-Wformat-security]
                                     [self explanatoryDialogText],
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Patch by Nico Weber <thakis@chromium.org>
Review URL: https://breakpad.appspot.com/607002


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1195 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
mark@chromium.org 2013-06-27 20:55:45 +00:00
parent d394434a93
commit f33dd18fd2
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/client/mac/sender/crash_report_sender.m
View file

@ -265,11 +265,13 @@ const int kEmailMaxLength = 64;
} }
} else { } else {
// Create an alert panel to tell the user something happened // Create an alert panel to tell the user something happened
NSPanel* alert = NSGetAlertPanel([self shortDialogMessage], NSPanel* alert =
[self explanatoryDialogText], NSGetAlertPanel([self shortDialogMessage],
@"%@",
NSLocalizedString(@"sendReportButton", @""), NSLocalizedString(@"sendReportButton", @""),
NSLocalizedString(@"cancelButton", @""), NSLocalizedString(@"cancelButton", @""),
nil); nil,
[self explanatoryDialogText]);
// Pop the alert with an automatic timeout, and wait for the response // Pop the alert with an automatic timeout, and wait for the response
buttonPressed = [self runModalWindow:alert withTimeout:timeout]; buttonPressed = [self runModalWindow:alert withTimeout:timeout];