Will Harris
2d450f312b
Fix regression on x86 for "Fix compile error with Windows clang"
...
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1318013002 .
2015-09-03 16:38:57 -07:00
wfh@chromium.org
9178d8fa03
Fix compile error with Windows clang.
...
This change fixes the following errors shown during compile with
Windows clang:
error: cannot pass non-trivial object of type 'ATL::CComBSTR' to variadic function; expected type from format string was 'wchar_t *' [-Wnon-pod-varargs]
Original CL: https://codereview.chromium.org/1252913009/
BUG=https://code.google.com/p/google-breakpad/issues/detail?id=662
Review URL: https://codereview.chromium.org/1307463003
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1494 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-08-19 22:28:17 +00:00
ted.mielczarek@gmail.com
bbd478ae73
Fix Windows dump_syms x64 linking
...
The dia_sdk GYP target points at the x86 diaguids.lib, it needs to
point at the x64 one for x64 builds.
R=mark at https://breakpad.appspot.com/9784002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1431 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-03-06 20:12:00 +00:00
ted.mielczarek@gmail.com
8aa26b79f9
Replace uses of hash_map with unordered_map
...
hash_map no longer exists in Visual C++ 2015.
A=Brian Smith <brian@briansmith.org>
R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=1119072
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1419 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-02-02 14:05:45 +00:00
ivanpe@chromium.org
e469f8cf4b
Add parameter --product to symupload.exe
...
Adding an optional parameter --product to symupload.exe. If specified it will be passed to the symbol server as POST parameter 'product'.
As part of this, I'm also fixing:
- Removed the .vcproj file as it can be generated from the .gyp file on demand.
- error C4335: Mac file format detected. Fixed the line endings for omap.cc and dia_util.cc.
- warning C4003: not enough actual parameters for macro 'max'
Symupload.exe was compiled using MSVS 2013 and DIA SDK 12.0.
Review URL: https://breakpad.appspot.com/9734002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1402 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-11-17 22:47:05 +00:00
ted.mielczarek@gmail.com
c971cf439c
Fix Windows client compilation on mingw.
...
A=Jacek Caban <jacek@codeweavers.com>, R=ted at http://breakpad.appspot.com/548002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1399 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-11-03 17:05:39 +00:00
mark@chromium.org
a58de86bcd
Back out trunk r1367.
...
Compile error: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091#c15
Review URL: https://breakpad.appspot.com/9694002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1369 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-09-03 13:40:40 +00:00
ted.mielczarek@gmail.com
8cde5c5152
Support for multiple upload files in CrashReportSender/HTTPUpload
...
A=David Major <dmajor@mozilla.com> R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=1048091
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1367 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-08-28 15:26:59 +00:00
wfh@chromium.org
9aaae65466
Change PrintFunctions to print functions in address order and not print duplicate public functions.
...
BUG=427
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1634002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-23 17:27:01 +00:00
wfh@chromium.org
c83a81450c
Change the way function and public symbols are obtained to use the findChildren DIA function.
...
This has a substantial performance improvement over using the getSymbolsByAddr iterator, especially on certain 64bit DLLS. e.g. Time to process chrome_child.dll drops from 51 minutes to 21 secs.
Note: new test data looks different because the ordering of lines is no longer by memory address. This does not affect processing. The test data has been manually compared to old data and matches (except additional PUBLIC symbols). Also, INFO lines are omitted because the source executable files are not checked in, so they are unavailable.
R=ivanpe@chromium.org , mark@chromium.org
Review URL: https://breakpad.appspot.com/1574002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1316 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-16 22:50:28 +00:00
ivan.penkov@gmail.com
6b0703a093
Adding support for 64-bit Windows modules to ms_symbol_server_converter.
...
As part of that:
- Updated MSSymbolServerConverter to also download the executable files from the symbol server and pass them to the PDBSourceLineWriter as it is required for successful conversion of symbols for 64-bit modules.
- Added a .gyp file and target for the ms_symbol_server_converter library.
- Updated PDBSourceLineWriter to allow executable files to be in locations different from the locations of the PDB files.
- Minor style issue:
* #define guards.
* No space before ')' and after '('.
R=mark@chromium.org , wfh@chromium.org
Review URL: https://breakpad.appspot.com/1434002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1309 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-10 17:54:52 +00:00
ivan.penkov@gmail.com
7dbca422d4
Moving directory 'build' one level up as it collides with a file named 'BUILD' which happens to be in that same location in the Google source depot.
...
R=chrisha@chromium.org , mark@chromium.org
Review URL: https://breakpad.appspot.com/1504002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1308 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-10 17:37:20 +00:00
chrisha@chromium.org
611f8b7f32
Move build configuration to root of repository.
...
This is in preparation for creating GYP build files for each platform.
BUG=https://code.google.com/p/google-breakpad/issues/detail?id=575
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1414002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1304 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-03 18:34:24 +00:00
wfh@chromium.org
213a0698cb
Add support for Win64 stack unwind data as STACK CFI
...
This is a copy of https://breakpad.appspot.com/1264002/ where code review took place.
See https://bugzilla.mozilla.org/show_bug.cgi?id=548035 and https://code.google.com/p/chromium/issues/detail?id=115922
Credit to Mikhail I. Izmestev <izmmishao5@gmail.com> for original patch in https://breakpad.appspot.com/345002/
BUG=572
TEST=Run dump_syms_unittest after compiling dump_syms_regtest.cc with x64 toolchain
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1274002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1290 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-03-24 12:12:17 +00:00
thestig@chromium.org
0864f0afaa
Fix missing semi-colons from r1267.
...
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1094002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1275 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-01-17 23:20:24 +00:00
thestig@chromium.org
4a0f9bf030
Windows: Fix remaining level 4 warnings.
...
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/954002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1267 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-18 22:43:56 +00:00
ivan.penkov@gmail.com
6b46d4e872
Treat warnings as error and fix most level 4 warnings in the breakpad windows client projects.
...
Some of the lint errors in the files touched by this change were also fixed.
BUG=533
Review URL: https://breakpad.appspot.com/601002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1189 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-06-04 16:51:01 +00:00
chrisha@chromium.org
8507f63d38
Add explicit OMAP support to dump_syms.
...
This CL adds new utilities to common/windows for handling OMAP information in
PDB files. It then augments PdbSourceLineWriter with explicit OMAP knowledge so
that symbolization will proceed more cleanly for images whose PDB files contain
OMAP information. This makes breakpad handle OMAPped symbol files as cleanly as
WinDbg.
Review URL: https://breakpad.appspot.com/570002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1167 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-05-01 18:18:46 +00:00
ted.mielczarek
cd77197264
Fix sizeof bug in HTTPUpload::SendRequest
...
A=Himanshu <only4coding@gmail.com> R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=710993
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@992 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-07-20 17:54:32 +00:00
ted.mielczarek
11ee73fc55
Add filename to error message when PDBSourceLineWriter::Open fails
...
P=Albert Zeyer
R=ted at http://breakpad.appspot.com/286002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@919 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-02-15 15:29:44 +00:00
vitalybuka@chromium.org
04023b1f6a
Fixed message about unregistered msdia*dll. Builds with different DiaSDK need different dll.
...
Rebuilt with Visual Studio 2008.
Slightly improved refresh_binaries.bat.
BUG=none
TEST=none
Review URL: http://breakpad.appspot.com/281001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@787 4c0a9323-5329-0410-9bdc-e9ce6186880e
2011-04-26 20:52:48 +00:00
ted.mielczarek
cff9fdbd94
enable writing INFO CODE_ID line in symbol files
...
R=mark (originally from http://breakpad.appspot.com/180001 )
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@773 4c0a9323-5329-0410-9bdc-e9ce6186880e
2011-02-15 13:39:08 +00:00
ted.mielczarek@gmail.com
7405ecd046
allow uploading zero-byte files in HTTPUpload
...
R=mark at http://breakpad.appspot.com/243001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@743 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-12-15 16:19:32 +00:00
ted.mielczarek
d35f113d02
Make dump_syms output an INFO CODE_ID line that includes the code file and code identifier. (Currently disabled to give Breakpad users time to update their processor code.)
...
R=mark at http://breakpad.appspot.com/180001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@710 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-10-05 19:39:23 +00:00
erikwright@chromium.org
7fde9a879d
Revert revision 658 ('Add glog style logging to symupload').
...
R=nealsid at http://breakpad.appspot.com/190001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@685 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-09-15 17:38:03 +00:00
ted.mielczarek
6c7d641dc9
Issue 370 - fix PDBSourceLineWriter::GetModuleInfo's CPU detection
...
R=nealsid at http://breakpad.appspot.com/181001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@678 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-08-31 15:08:49 +00:00
ted.mielczarek
3b7d8ee362
Disable cookies in Windows HTTPUpload
...
R=nealsid at http://breakpad.appspot.com/161001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@661 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-08-20 12:19:38 +00:00
nealsid@gmail.com
e167e9e61f
Add glog style logging to symupload
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@658 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-08-19 21:53:35 +00:00
ted.mielczarek
873064894b
don't output duplicate filenames in PDBSourceLineWriter. r=mark at http://breakpad.appspot.com/43001
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@431 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-11-23 14:50:55 +00:00
ted.mielczarek
927cc8fa2a
output function names for PGO-optimized cold function blocks. r=mark at http://breakpad.appspot.com/40007
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@430 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-11-20 18:24:41 +00:00
nealsid
2a4698319a
Fix up warnings when building http_upload.cc. Changed warning level to /W4, and also turned off deprecated 64-bit compatability warning flag(since some people are regularly building Breakpad in 64-bit mode, if we turn off this flag we get rid of a warning in 32 bit mode under VS2008)
...
R=mmentovai
A=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@340 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-05-27 16:54:23 +00:00
nealsid
3366749ee7
Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files).
...
R=doshimun
W=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-20 19:02:12 +00:00
ted.mielczarek
c1e0783204
Use swprintf_s for VC8 or newer. r=mento
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@238 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-02-04 20:50:07 +00:00
mmentovai
bbd9b47291
The string buffer lengths in a URL_COMPONENTS structure are in TCHARs, so
...
these should be sizeof(z) / sizeof(z[0]) to avoid a buffer overrun. Caught
by Dmitry Titov, r=me.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@229 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-11-13 22:17:14 +00:00
mmentovai
f2fa084fd2
Fix compiler warning C4245: signed/unsigned mismatch when converting between
...
types. Patch by Sorin Jianu. r=me,bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@217 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-28 16:27:56 +00:00
bryner
28c645f3ee
Silences warning C4701: local variable 'claimed_size' may be used with out
...
having been initialized. The code is correct however the compiler can't see
the relationship between has_content_length_header and the claimed_size so it
generates a warning.
Patch from Sorin Jianu, r=bryner
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@211 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-09-20 21:48:47 +00:00
ted.mielczarek
684649a571
Issue 42 - check for non-existent dump file in HTTPUpload::SendRequest. r=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@186 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-06-01 11:47:28 +00:00
mmentovai
329e6a9630
Emergency crash fix, tbr=bryner
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@147 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-25 15:17:19 +00:00
mmentovai
29789d8106
Wrong version of swprintf used with VS 2003/7.1 CRT. r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/eadfa703d4bd8a4a
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@143 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-09 18:35:20 +00:00
mmentovai
30fc9ce1c0
Replace GB_WSU_SAFE_SWPRINTF_TERMINATE with inline code ( #145 followup).
...
r=bryner
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/f77da3d219cf9388
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@140 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-04 16:13:55 +00:00
mmentovai
1de8bed899
Windows http_upload should allow response without Content-Length header ( #144 ).
...
Patch by Ted Mielczarek. r=me
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/a401434f639e5b2f
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@136 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-04-02 18:24:16 +00:00
mmentovai
aec44489da
vswprintf causes Purify to fail ( #145 ). r=darin
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/88e18d9fac4eee22
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@135 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-30 20:30:08 +00:00
mmentovai
6bc866cc82
Don't output FUNC lines for 0-length functions ( #139 ). r=bryner
...
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/c684520587356ec3
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@129 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-03-22 21:10:30 +00:00
mmentovai
e5dc60822e
Rename Airbag to Breakpad.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@122 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-02-14 19:51:05 +00:00
mmentovai
50e299b00e
Library to handle SymSrv integration ( #111 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/b40e66d1d57e61b5
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@105 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-18 21:13:14 +00:00
incrementalist
d4e527b7ee
Allows the caller of CrashReportSender::SendCrashReport() to determine that
...
the server rejected a crash report, by changing the return value from a
boolean to a tri-state enum.
Fixes issue #101 . Reviewed by mmentovai.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@99 4c0a9323-5329-0410-9bdc-e9ce6186880e
2007-01-03 23:14:46 +00:00
mmentovai
c7b6c11f32
Fix capitalization of identifiers ( #94 ). r=bryner
...
http://groups.google.com/group/airbag-dev/browse_thread/thread/15cf4d0ce5ed1014
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@85 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-12 21:52:56 +00:00
bryner
fd38d48e6d
Add an abstract interface to SourceLineResolver, and allow any implementation
...
to be used with MinidumpProcessor. The basic SourceLineResolver is now a
public interface (#89 )
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@83 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-11 23:22:54 +00:00
incrementalist
dd7c38baae
This patch fixes Airbag issue #44 .
...
Summary of this patch:
* It adds a new wstring* parameter to the end of both
SendCrashReport() and HTTPUpload::SendRequest(), which can be NULL.
* If the request isn't successful, the result parameter isn't touched.
* It adds HTTPUpload::UTF8ToWide() to allow the response to be
returned as a wstring,
* It changes the return value of SendRequest (and by extension,
SendCrashReport) so that if the size of the response body isn't
exactly the same as the value given in the Content-Length header, the
return value is false (in addition to the previous semantics).
* It also updates symupload.cc to account for the new parameter in
SendRequest().
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@81 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-08 20:45:20 +00:00
mmentovai
93fa375b58
symupload parameters don't match processor expectations ( #91 ). r=bryner
...
- Interface change: the "guid" and "age" parameters supplied to a symbol
server by symupload have been merged into "debug_identifier". Some
other parameters have had their names changed. Additional code_file,
os, and cpu parameters have been added.
- Interface change: the format of the MODULE line at the top of dumped .sym
files has changed slightly. The fields used for uuid and age have
merged into a debug_identifier-type field.
- debug_identifier is formatted the same way as CodeModule::debug_identifier
for ease of server-side processing.
http://groups.google.com/group/airbag-dev/browse_thread/thread/8022f504cf01f994
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@77 4c0a9323-5329-0410-9bdc-e9ce6186880e
2006-12-06 20:18:26 +00:00