breakpad/src/common/mac
Mark Mentovai 01dfa81f1b Mac dump_syms: accept __DWARF segment without __debug_info section
A .dSYM may validly contain a __DWARF segment without any __debug_info
section. This can occur for Chromium Framework in a component build of
Chromium, because in that case, all of the code is in other libraries
that Chromium Framework depends on.

This was previously tested by an assertion, but the assertion did not
trigger in NDEBUG (release) builds. In NDEBUG builds, this condition
would lead to an out-of-bounds read, detected by AddressSanitizer.

Instead of an assertion, the check is now always done at runtime.
Instead of being fatal, it's now just a warning, because it's been
established that __DWARF without __debug_info can occur.

(In the Chromium case, it remains pointless to run dump_syms via the
"chrome_dump_syms" target on a component build, as it'll only attempt to
symbolize Chromium Framework, and not any of the libraries that Chromium
Framework depends on that actually contain the code.)

Bug: chromium:991206
Change-Id: I6c9c75f0be7901813e3eaae54aff38c1afe73ca9
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1741610
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2019-08-07 16:43:11 +00:00
..
testing Remove GTM_ENABLE_LEAKS and GTMGarbageCollection 2016-04-21 13:20:17 -07:00
arch_utilities.cc Add mac dump_syms support for arm64e 2018-11-26 18:29:35 +00:00
arch_utilities.h Add custom implementation of NXGetArchInfoXXX to allow adding new arch. 2012-10-03 16:20:53 +00:00
bootstrap_compat.cc Funnel all bootstrap_register calls through a routine that doesn't care that 2012-02-21 21:24:43 +00:00
bootstrap_compat.h Funnel all bootstrap_register calls through a routine that doesn't care that 2012-02-21 21:24:43 +00:00
Breakpad.xcconfig Fixes up dump_syms build on OS X so it works with ELF. 2016-05-12 11:38:09 -07:00
BreakpadDebug.xcconfig Clean up build for 64 bit. 2010-07-19 20:43:49 +00:00
BreakpadRelease.xcconfig Rewrite SimpleStringDictionary with NonAllocatingMap. 2013-04-24 18:15:48 +00:00
byteswap.h Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
dump_syms.cc Mac dump_syms: accept __DWARF segment without __debug_info section 2019-08-07 16:43:11 +00:00
dump_syms.h Mac dump_syms: accept __DWARF segment without __debug_info section 2019-08-07 16:43:11 +00:00
file_id.cc Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
file_id.h breakpad: Remove semicolons, iOS edition. 2019-02-25 21:43:47 +00:00
GTMDefines.h Update links 2016-11-18 17:24:37 +00:00
GTMLogger.h Update GTM files to latest from 2012-09-21 07:55:17 +00:00
GTMLogger.m Update GTM and enable -Wundef and strict C++11 flags. 2014-02-26 16:14:04 +00:00
HTTPMultipartUpload.h Use right header. 2011-10-10 14:43:03 +00:00
HTTPMultipartUpload.m Increase timeout of HTTPMultipartUpload from 10s to 60s. 2019-05-13 20:24:15 +00:00
launch_reporter.cc Mac: Add support for in-process crash reporting to Breakpad. 2014-09-15 22:48:18 +00:00
launch_reporter.h Mac: Add support for in-process crash reporting to Breakpad. 2014-09-15 22:48:18 +00:00
MachIPC.h breakpad: Remove semicolons, mac edition. 2019-02-22 16:53:33 +00:00
MachIPC.mm Funnel all bootstrap_register calls through a routine that doesn't care that 2012-02-21 21:24:43 +00:00
macho_id.cc Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
macho_id.h Update dump_syms to correctly filter on cpu subtype. 2012-10-04 13:26:47 +00:00
macho_reader.cc mac dump_syms: remove unused vars to fix -Werror build failures 2019-04-05 00:25:48 +00:00
macho_reader.h mac dump_syms: Support .dSYMs > 4GB (partially) 2019-03-28 20:43:54 +00:00
macho_reader_unittest.cc macho_reader_unittest: use EXPECT_FALSE 2017-02-12 18:51:38 +00:00
macho_utilities.cc Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
macho_utilities.h Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
macho_walker.cc Fix Mac Breakpad host tools to build in Linux cross-compile 2015-09-16 06:46:55 -04:00
macho_walker.h Update dump_syms to correctly filter on cpu subtype. 2012-10-04 13:26:47 +00:00
scoped_task_suspend-inl.h Implement CrashGeneration{Client,Server} for OOP dump generation on OS X, enable OOP dump generation in ExceptionHandler 2010-08-13 20:18:58 +00:00
string_utilities.cc Move scoped_ptr.h to common 2013-01-17 15:53:56 +00:00
string_utilities.h Add Mac string utilities. Reviewed by mmentovai. Fixes issue #98. 2006-12-19 22:11:46 +00:00
super_fat_arch.h Support object files larger than 2**32. 2015-04-22 20:14:24 +00:00