mirror of
https://github.com/yuzu-emu/breakpad.git
synced 2024-12-23 10:15:39 +00:00
70f5af9444
Change MinidumpModuleList::GetMainModule() to use GetModuleAtIndex() instead of GetModuleAtSequence() because the former gets the first module that was in the minidump file, while the latter actually gets the first module when sorted by address. While this is pretty much the same thing at the moment, I have another change in the works that can sometimes affect the module order in the file. BUG=chromium-os:25355 TEST=Ran Breakpad tests Review URL: https://breakpad.appspot.com/366001 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@941 4c0a9323-5329-0410-9bdc-e9ce6186880e |
||
---|---|---|
autotools | ||
m4 | ||
src | ||
aclocal.m4 | ||
AUTHORS | ||
ChangeLog | ||
codereview.settings | ||
configure | ||
configure.ac | ||
COPYING | ||
DEPS | ||
INSTALL | ||
Makefile.am | ||
Makefile.in | ||
NEWS | ||
README |
Breakpad is a set of client and server components which implement a crash-reporting system. ----- Getting started in 32-bit mode (from trunk) Configure: CXXFLAGS=-m32 CFLAGS=-m32 CPPFLAGS=-m32 ./configure Build: make Test: make check Install: make install If you need to reconfigure your build be sure to run "make distclean" first. ----- To request change review: 0. Get access to a read-write copy of source. Owners at http://code.google.com/p/google-breakpad/ are able to grant this access. 1. Check out a read-write copy of source using instructions at http://code.google.com/p/google-breakpad/source/checkout 2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file. 3. Download http://codereview.appspot.com/static/upload.py 4. Run upload.py from the 'src' directory: upload.py --server=breakpad.appspot.com You will be prompted for credential and a description. 5. At http://breakpad.appspot.com you'll find your issue listed; click on it, and select Publish+Mail, and enter in the code reviewer and CC google-breakpad-dev@googlegroups.com 6. When applying code review feedback, specify the '-i' option when running upload.py again and pass the issue number so it updates the existing issue, rather than creating a new one. Be sure to rerun upload.py from the same directory as you did for previous uploads to allow for proper diff calculations.