mirror of
https://github.com/yuzu-emu/breakpad.git
synced 2025-01-10 13:05:43 +00:00
9b23ca3a7c
If the mapping for the main executable needed to be merged (for example, if it was linked with lld and therefore contains an r mapping followed by an r/x mapping), we would never reach the code that makes it the first module. Handle that situation by moving that code into a separate loop. This fixes an issue where breakpad_unittests fails on Android devices when linked with lld. It appears that the glibc dynamic loader happens to always load executables (or at least the executables that we create) at a lower address than DSOs, so we never hit this bug on desktop Linux. Testing: "make check" with both gold and lld as linker. Also breakpad_unittests when patched into Chromium on Linux (lld) and Android (gold and lld). Bug: chromium:469376 Change-Id: I6329e4afd2f1bf44c25a6c3e684495e21dba83a6 Reviewed-on: https://chromium-review.googlesource.com/722286 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> |
||
---|---|---|
.. | ||
apple/Framework | ||
ios | ||
linux | ||
mac | ||
solaris/handler | ||
windows | ||
minidump_file_writer-inl.h | ||
minidump_file_writer.cc | ||
minidump_file_writer.h | ||
minidump_file_writer_unittest.cc |