ivan.penkov@gmail.com d394434a93 This change is addressing a particularly nasty issue where the stackwalker ... doesn't see the correct thread stack memory. Instead, it loads garbage (from offset 0 of the minidump file - well that's not garbage, but it is not the stack memory region either) and attempts to walk it. A typical symptom of this issue is when you get a single stack frame after processing - the context frame - for which you don't need stack memory. This issue is caused by an invalid RVA in the memory descriptor stored inside the MINIDUMP_THREAD structure for the thread. Luckily, the invalid RVA is 0, and the start_of_memory_region appears to be correct, so this issue can be easily detected and the correct memory region can be loaded using an RVA specified in the MinidumpMemoryList. I couldn't find a reasonable description on MSDN regarding MINIDUMP_MEMORY_DESCRIPTOR.MINIDUMP_LOCATION_DESCRIPTOR having RVA of 0 except maybe for full dumps where the 64-bit version of the structure (MINIDUMP_MEMORY_DESCRIPTOR64) is used and it has no RVA at all. It has a 64-bit DataSize which if interpreted as the 32-bit structure will very likely result in 0 for the RVA: http://msdn.microsoft.com/en-us/library/windows/desktop/ms680384(v=vs.85).aspx Anyways, the dump that I looked at was not a full dump so 0 for RVA is a bit puzzling (at least easily detectable): ... Microsoft (R) Windows Debugger Version 6.2.9200.20512 X86 Copyright (c) Microsoft Corporation. All rights reserved. ... User Mini Dump File: Only registers, stack and portions of memory are available ... MINIDUMP_HEADER: Version A793 (62F0) NumberOfStreams 11 Flags 160 0020 MiniDumpWithUnloadedModules 0040 MiniDumpWithIndirectlyReferencedMemory 0100 MiniDumpWithProcessThreadData Review URL: https://breakpad.appspot.com/606002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1194 4c0a9323-5329-0410-9bdc-e9ce6186880e		2013-06-27 20:34:30 +00:00
..
client	add interface for WriteMinidump which allows the caller to supply file handles instead of paths where the minidumps should be written.	2013-06-06 17:20:34 +00:00
common	Eliminate redundant initialization following r1188,	2013-06-20 18:20:48 +00:00
google_breakpad	This change is addressing a particularly nasty issue where the stackwalker	2013-06-27 20:34:30 +00:00
processor	This change is addressing a particularly nasty issue where the stackwalker	2013-06-27 20:34:30 +00:00
third_party	Fix a "set but not used" compiler warning in libdisasm	2013-05-10 15:49:23 +00:00
tools	Check in new Windows binaries.	2013-05-09 16:29:56 +00:00
breakpad_googletest_includes.h	Add more error information to minidump processing return code. Also added dependency on google test, and modified minidump processing unit tests to use google test	2009-05-29 00:53:02 +00:00
config.h.in	Remove NetworkSourceLine{Resolver,Server} and related code. It never wound up being useful enough to use in production, so let's drop the maintenence burden	2011-07-07 20:53:52 +00:00