mirror of
https://github.com/yuzu-emu/breakpad.git
synced 2025-11-11 05:15:00 +00:00
01431c2f61
The main motivation for this change is to handle very large stack traces, normally the result of infinite recursion. This part is actually fairly simple, relaxing a few self-imposed limits on how many frames we can unwind and the max size for stack memory. Relaxing these limits requires stricter and more consistent checks for stack unwinding. There are a number of unwinding invariants that apply to all the platforms: 1. stack pointer (and frame pointer) must be within the stack memory (frame pointer, if preset, must point to the right frame too) 2. unwinding must monotonically increase SP (except for the first frame unwind, this must be a strict increase) 3. Instruction pointer (return address) must point to a valid location 4. stack pointer (and frame pointer) must be appropriately aligned This change is focused on 2), which is enough to guarantee that the unwinding doesn't get stuck in an infinite loop. 1) is implicitly validated part of accessing the stack memory (explicit checks might be nice though). 4) is ABI specific and while it may be valuable in catching suspicious frames is not in the scope of this change. 3) is also an interesting check but thanks to just-in-time compilation it's more complex than just calling StackWalker::InstructionAddressSeemsValid() and we don't want to drop parts of the callstack due to an overly conservative check. Bug: chromium:735989 Change-Id: I9aaba77c7fd028942d77c87d51b5e6f94e136ddd Reviewed-on: https://chromium-review.googlesource.com/563771 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
109 lines
4.5 KiB
C++
109 lines
4.5 KiB
C++
// Copyright (c) 2010 Google Inc.
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following disclaimer
|
|
// in the documentation and/or other materials provided with the
|
|
// distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived from
|
|
// this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// stackwalker_amd64.h: amd64-specific stackwalker.
|
|
//
|
|
// Provides stack frames given amd64 register context and a memory region
|
|
// corresponding to a amd64 stack.
|
|
//
|
|
// Author: Mark Mentovai, Ted Mielczarek
|
|
|
|
|
|
#ifndef PROCESSOR_STACKWALKER_AMD64_H__
|
|
#define PROCESSOR_STACKWALKER_AMD64_H__
|
|
|
|
#include <vector>
|
|
|
|
#include "google_breakpad/common/breakpad_types.h"
|
|
#include "google_breakpad/common/minidump_format.h"
|
|
#include "google_breakpad/processor/stackwalker.h"
|
|
#include "google_breakpad/processor/stack_frame_cpu.h"
|
|
#include "processor/cfi_frame_info.h"
|
|
|
|
namespace google_breakpad {
|
|
|
|
class CodeModules;
|
|
|
|
class StackwalkerAMD64 : public Stackwalker {
|
|
public:
|
|
// context is a amd64 context object that gives access to amd64-specific
|
|
// register state corresponding to the innermost called frame to be
|
|
// included in the stack. The other arguments are passed directly through
|
|
// to the base Stackwalker constructor.
|
|
StackwalkerAMD64(const SystemInfo* system_info,
|
|
const MDRawContextAMD64* context,
|
|
MemoryRegion* memory,
|
|
const CodeModules* modules,
|
|
StackFrameSymbolizer* frame_symbolizer);
|
|
|
|
private:
|
|
// A STACK CFI-driven frame walker for the AMD64
|
|
typedef SimpleCFIWalker<uint64_t, MDRawContextAMD64> CFIWalker;
|
|
|
|
// Implementation of Stackwalker, using amd64 context (stack pointer in %rsp,
|
|
// stack base in %rbp) and stack conventions (saved stack pointer at 0(%rbp))
|
|
virtual StackFrame* GetContextFrame();
|
|
virtual StackFrame* GetCallerFrame(const CallStack* stack,
|
|
bool stack_scan_allowed);
|
|
|
|
// Use cfi_frame_info (derived from STACK CFI records) to construct
|
|
// the frame that called frames.back(). The caller takes ownership
|
|
// of the returned frame. Return NULL on failure.
|
|
StackFrameAMD64* GetCallerByCFIFrameInfo(const vector<StackFrame*> &frames,
|
|
CFIFrameInfo* cfi_frame_info);
|
|
|
|
// Assumes a traditional frame layout where the frame pointer has not been
|
|
// omitted. The expectation is that caller's %rbp is pushed to the stack
|
|
// after the return address of the callee, and that the callee's %rsp can
|
|
// be used to find the pushed %rbp.
|
|
// Caller owns the returned frame object. Returns NULL on failure.
|
|
StackFrameAMD64* GetCallerByFramePointerRecovery(
|
|
const vector<StackFrame*>& frames);
|
|
|
|
// Scan the stack for plausible return addresses. The caller takes ownership
|
|
// of the returned frame. Return NULL on failure.
|
|
StackFrameAMD64* GetCallerByStackScan(const vector<StackFrame*> &frames);
|
|
|
|
// Stores the CPU context corresponding to the innermost stack frame to
|
|
// be returned by GetContextFrame.
|
|
const MDRawContextAMD64* context_;
|
|
|
|
// Our register map, for cfi_walker_.
|
|
static const CFIWalker::RegisterSet cfi_register_map_[];
|
|
|
|
// Our CFI frame walker.
|
|
const CFIWalker cfi_walker_;
|
|
};
|
|
|
|
|
|
} // namespace google_breakpad
|
|
|
|
|
|
#endif // PROCESSOR_STACKWALKER_AMD64_H__
|