component_test_cmake_out_of_source: simplify and fix error handling

Remove ssl-opt.err even if it's empty.

Call cat unconditionally: it'll have no visible effect if the file is
empty.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2020-03-28 18:56:09 +01:00 committed by Thomas Daubney
parent 8ab2994eb5
commit 0a7984f1dd

View file

@ -2737,11 +2737,10 @@ component_test_cmake_out_of_source () {
# file is missing (ssl-opt.sh tolerates the absence of some files so
# may exit with status 0 but emit errors).
if_build_succeeded ./tests/ssl-opt.sh -f 'Fallback SCSV: beginning of list' 2>ssl-opt.err
if [ -s ssl-opt.err ]; then
cat ssl-opt.err >&2
record_status [ ! -s ssl-opt.err ]
rm ssl-opt.err
fi
cat ssl-opt.err >&2
# If ssl-opt.err is non-empty, record an error and keep going.
record_status [ ! -s ssl-opt.err ]
rm ssl-opt.err
cd "$MBEDTLS_ROOT_DIR"
rm -rf "$OUT_OF_SOURCE_DIR"
unset MBEDTLS_ROOT_DIR