yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-12-26 01:15:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove "handshake" input from populate_transform()

Browse source
This commit is contained in:
Manuel Pégourié-Gonnard 2019-05-06 13:32:17 +02:00
parent 12a3f445b6
commit 0bcfbc3e04
1 changed files with 29 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
library/ssl_tls.c
View file

@ -607,6 +607,11 @@ static void ssl_calc_finished_tls_sha384( mbedtls_ssl_context *, unsigned char *
#endif #endif
#endif /* MBEDTLS_SSL_PROTO_TLS1_2 */ #endif /* MBEDTLS_SSL_PROTO_TLS1_2 */
/* Type for the TLS PRF */
typedef int ssl_tls_prf_t(const unsigned char *, size_t, const char *,
const unsigned char *, size_t,
unsigned char *, size_t);
/* /*
* Populate a transform structure with session keys and all the other * Populate a transform structure with session keys and all the other
* necessary information. * necessary information.
@ -615,13 +620,15 @@ static void ssl_calc_finished_tls_sha384( mbedtls_ssl_context *, unsigned char *
* - [in/out]: transform: structure to populate * - [in/out]: transform: structure to populate
* [in] must be just initialised with mbedtls_ssl_transform_init() * [in] must be just initialised with mbedtls_ssl_transform_init()
* [out] fully populate, ready for use by mbedtls_ssl_{en,de}crypt_buf() * [out] fully populate, ready for use by mbedtls_ssl_{en,de}crypt_buf()
* - [in] session: used members: encrypt_then_max, master, compression * - [in] session: used: ciphersuite, encrypt_then_mac, master, compression
* - [in] handshake: used members: prf, ciphersuite_info, randbytes * - [in] tls_prf: pointer to PRF to use for key derivation
* - [in]: ssl: used members: minor_ver, conf->endpoint * - [in] randbytes: buffer holding ServerHello.random + ClientHello.random
* - [in] ssl: used members: minor_ver, conf->endpoint
*/ */
static int ssl_populate_transform( mbedtls_ssl_transform *transform, static int ssl_populate_transform( mbedtls_ssl_transform *transform,
const mbedtls_ssl_session *session, const mbedtls_ssl_session *session,
const mbedtls_ssl_handshake_params *handshake, ssl_tls_prf_t tls_prf,
const unsigned char randbytes[64],
const mbedtls_ssl_context *ssl ) const mbedtls_ssl_context *ssl )
{ {
int ret = 0; int ret = 0;
@ -637,12 +644,23 @@ static int ssl_populate_transform( mbedtls_ssl_transform *transform,
const mbedtls_cipher_info_t *cipher_info; const mbedtls_cipher_info_t *cipher_info;
const mbedtls_md_info_t *md_info; const mbedtls_md_info_t *md_info;
/* Copy info about negotiated version and extensions */
#if defined(MBEDTLS_SSL_ENCRYPT_THEN_MAC) #if defined(MBEDTLS_SSL_ENCRYPT_THEN_MAC)
transform->encrypt_then_mac = session->encrypt_then_mac; transform->encrypt_then_mac = session->encrypt_then_mac;
#endif #endif
transform->minor_ver = ssl->minor_ver; transform->minor_ver = ssl->minor_ver;
ciphersuite_info = handshake->ciphersuite_info; /*
* Get various info structures
*/
ciphersuite_info = mbedtls_ssl_ciphersuite_from_id( session->ciphersuite );
if( ciphersuite_info == NULL )
{
MBEDTLS_SSL_DEBUG_MSG( 1, ( "ciphersuite info for %d not found",
session->ciphersuite ) );
return( MBEDTLS_ERR_SSL_BAD_INPUT_DATA );
}
cipher_info = mbedtls_cipher_info_from_type( ciphersuite_info->cipher ); cipher_info = mbedtls_cipher_info_from_type( ciphersuite_info->cipher );
if( cipher_info == NULL ) if( cipher_info == NULL )
{ {
@ -660,19 +678,10 @@ static int ssl_populate_transform( mbedtls_ssl_transform *transform,
} }
/* /*
* SSLv3: * Compute key block using the PRF
* key block =
* MD5( master + SHA1( 'A' + master + randbytes ) ) +
* MD5( master + SHA1( 'BB' + master + randbytes ) ) +
* MD5( master + SHA1( 'CCC' + master + randbytes ) ) +
* MD5( master + SHA1( 'DDDD' + master + randbytes ) ) +
* ...
*
* TLSv1:
* key block = PRF( master, "key expansion", randbytes )
*/ */
ret = handshake->tls_prf( session->master, 48, "key expansion", ret = tls_prf( session->master, 48, "key expansion",
handshake->randbytes, 64, keyblk, 256 ); randbytes, 64, keyblk, 256 );
if( ret != 0 ) if( ret != 0 )
{ {
MBEDTLS_SSL_DEBUG_RET( 1, "prf", ret ); MBEDTLS_SSL_DEBUG_RET( 1, "prf", ret );
@ -682,7 +691,7 @@ static int ssl_populate_transform( mbedtls_ssl_transform *transform,
MBEDTLS_SSL_DEBUG_MSG( 3, ( "ciphersuite = %s", MBEDTLS_SSL_DEBUG_MSG( 3, ( "ciphersuite = %s",
mbedtls_ssl_get_ciphersuite_name( session->ciphersuite ) ) ); mbedtls_ssl_get_ciphersuite_name( session->ciphersuite ) ) );
MBEDTLS_SSL_DEBUG_BUF( 3, "master secret", session->master, 48 ); MBEDTLS_SSL_DEBUG_BUF( 3, "master secret", session->master, 48 );
MBEDTLS_SSL_DEBUG_BUF( 4, "random bytes", handshake->randbytes, 64 ); MBEDTLS_SSL_DEBUG_BUF( 4, "random bytes", randbytes, 64 );
MBEDTLS_SSL_DEBUG_BUF( 4, "key block", keyblk, 256 ); MBEDTLS_SSL_DEBUG_BUF( 4, "key block", keyblk, 256 );
/* /*
@ -1177,7 +1186,8 @@ int mbedtls_ssl_derive_keys( mbedtls_ssl_context *ssl )
/* Populate transform structure */ /* Populate transform structure */
ret = ssl_populate_transform( ssl->transform_negotiate, ret = ssl_populate_transform( ssl->transform_negotiate,
ssl->session_negotiate, ssl->session_negotiate,
ssl->handshake, ssl->handshake->tls_prf,
ssl->handshake->randbytes,
ssl ); ssl );
if( ret != 0 ) if( ret != 0 )
{ {