yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-02-24 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Factor more code into x509_get_pubkey()

Browse source
This commit is contained in:
Manuel Pégourié-Gonnard 2013-07-09 12:13:24 +02:00 committed by Paul Bakker
parent 788db112a5
commit 20c12f6b5f
1 changed files with 23 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

85
library/x509parse.c
View file

@ -545,7 +545,7 @@ static int x509_get_dates( unsigned char **p,
*/ */
static int x509_get_pubkey( unsigned char **p, static int x509_get_pubkey( unsigned char **p,
const unsigned char *end, const unsigned char *end,
mpi *N, mpi *E ) rsa_context *rsa )
{ {
int ret; int ret;
size_t len; size_t len;
@ -553,6 +553,14 @@ static int x509_get_pubkey( unsigned char **p,
unsigned char *end2; unsigned char *end2;
pk_type_t pk_alg = POLARSSL_PK_NONE; pk_type_t pk_alg = POLARSSL_PK_NONE;
if( ( ret = asn1_get_tag( p, end, &len,
ASN1_CONSTRUCTED | ASN1_SEQUENCE ) ) != 0 )
{
return( POLARSSL_ERR_X509_CERT_INVALID_FORMAT + ret );
}
end = *p + len;
if( ( ret = asn1_get_alg_null( p, end, &pk_alg_oid ) ) != 0 ) if( ( ret = asn1_get_alg_null( p, end, &pk_alg_oid ) ) != 0 )
return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + ret ); return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + ret );
@ -593,14 +601,19 @@ static int x509_get_pubkey( unsigned char **p,
return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY +
POLARSSL_ERR_ASN1_LENGTH_MISMATCH ); POLARSSL_ERR_ASN1_LENGTH_MISMATCH );
if( ( ret = asn1_get_mpi( p, end2, N ) ) != 0 || if( ( ret = asn1_get_mpi( p, end2, &rsa->N ) ) != 0 ||
( ret = asn1_get_mpi( p, end2, E ) ) != 0 ) ( ret = asn1_get_mpi( p, end2, &rsa->E ) ) != 0 )
return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + ret ); return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + ret );
if( *p != end ) if( *p != end )
return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY + return( POLARSSL_ERR_X509_CERT_INVALID_PUBKEY +
POLARSSL_ERR_ASN1_LENGTH_MISMATCH ); POLARSSL_ERR_ASN1_LENGTH_MISMATCH );
if( ( ret = rsa_check_pubkey( rsa ) ) != 0 )
return( ret );
rsa->len = mpi_size( &rsa->N );
return( 0 ); return( 0 );
} }
@ -1366,32 +1379,15 @@ static int x509parse_crt_der_core( x509_cert *crt, const unsigned char *buf,
crt->subject_raw.len = p - crt->subject_raw.p; crt->subject_raw.len = p - crt->subject_raw.p;
/* /*
* SubjectPublicKeyInfo ::= SEQUENCE * SubjectPublicKeyInfo
* algorithm AlgorithmIdentifier,
* subjectPublicKey BIT STRING }
*/ */
if( ( ret = asn1_get_tag( &p, end, &len, if( ( ret = x509_get_pubkey( &p, end,
ASN1_CONSTRUCTED | ASN1_SEQUENCE ) ) != 0 ) &crt->rsa ) ) != 0 )
{
x509_free( crt );
return( POLARSSL_ERR_X509_CERT_INVALID_FORMAT + ret );
}
if( ( ret = x509_get_pubkey( &p, p + len,
&crt->rsa.N, &crt->rsa.E ) ) != 0 )
{ {
x509_free( crt ); x509_free( crt );
return( ret ); return( ret );
} }
if( ( ret = rsa_check_pubkey( &crt->rsa ) ) != 0 )
{
x509_free( crt );
return( ret );
}
crt->rsa.len = mpi_size( &crt->rsa.N );
/* /*
* issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL, * issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL,
* -- If present, version shall be v2 or v3 * -- If present, version shall be v2 or v3
@ -1440,6 +1436,9 @@ static int x509parse_crt_der_core( x509_cert *crt, const unsigned char *buf,
end = crt_end; end = crt_end;
/* /*
* }
* -- end of TBSCertificate
*
* signatureAlgorithm AlgorithmIdentifier, * signatureAlgorithm AlgorithmIdentifier,
* signatureValue BIT STRING * signatureValue BIT STRING
*/ */
@ -2613,43 +2612,7 @@ int x509parse_public_key_rsa( rsa_context *rsa,
#endif #endif
end = p + keylen; end = p + keylen;
/* if( ( ret = x509_get_pubkey( &p, end, rsa ) ) != 0 )
* PublicKeyInfo ::= SEQUENCE {
* algorithm AlgorithmIdentifier,
* PublicKey BIT STRING
* }
*
* AlgorithmIdentifier ::= SEQUENCE {
* algorithm OBJECT IDENTIFIER,
* parameters ANY DEFINED BY algorithm OPTIONAL
* }
*
* RSAPublicKey ::= SEQUENCE {
* modulus INTEGER, -- n
* publicExponent INTEGER -- e
* }
*/
if( ( ret = asn1_get_tag( &p, end, &len,
ASN1_CONSTRUCTED | ASN1_SEQUENCE ) ) != 0 )
{
#if defined(POLARSSL_PEM_C)
pem_free( &pem );
#endif
rsa_free( rsa );
return( POLARSSL_ERR_X509_CERT_INVALID_FORMAT + ret );
}
if( ( ret = x509_get_pubkey( &p, end, &rsa->N, &rsa->E ) ) != 0 )
{
#if defined(POLARSSL_PEM_C)
pem_free( &pem );
#endif
rsa_free( rsa );
return( POLARSSL_ERR_X509_KEY_INVALID_FORMAT + ret );
}
if( ( ret = rsa_check_pubkey( rsa ) ) != 0 )
{ {
#if defined(POLARSSL_PEM_C) #if defined(POLARSSL_PEM_C)
pem_free( &pem ); pem_free( &pem );
@ -2658,8 +2621,6 @@ int x509parse_public_key_rsa( rsa_context *rsa,
return( ret ); return( ret );
} }
rsa->len = mpi_size( &rsa->N );
#if defined(POLARSSL_PEM_C) #if defined(POLARSSL_PEM_C)
pem_free( &pem ); pem_free( &pem );
#endif #endif