Avoid unnecessary xxx_copy() calls

The call would anyway check for pointer equality and return early, but it
doesn't hurt to save a function call, and also this follows more uniformly the
pattern that those two lines go together:

    #if defined(MBEDTLS_ECP_RESTARTBLE)
    if( rs_ctx != NULL && ...
This commit is contained in:
Manuel Pégourié-Gonnard 2017-08-23 17:33:27 +02:00
parent 5bd38b1144
commit 28d162829b
2 changed files with 4 additions and 2 deletions

View file

@ -353,7 +353,8 @@ modn:
while( mbedtls_mpi_cmp_int( s, 0 ) == 0 );
#if defined(MBEDTLS_ECP_RESTARTABLE)
mbedtls_mpi_copy( r, pr );
if( rs_ctx != NULL && rs_ctx->sig != NULL )
mbedtls_mpi_copy( r, pr );
#endif
cleanup:

View file

@ -1804,7 +1804,8 @@ static int ecp_mul_comb_after_precomp( const mbedtls_ecp_group *grp,
MBEDTLS_MPI_CHK( ecp_normalize_jac( grp, RR ) );
#if defined(MBEDTLS_ECP_RESTARTABLE)
MBEDTLS_MPI_CHK( mbedtls_ecp_copy( R, RR ) );
if( rs_ctx != NULL && rs_ctx->rsm != NULL )
MBEDTLS_MPI_CHK( mbedtls_ecp_copy( R, RR ) );
#endif
cleanup: