yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-01-22 23:51:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in psa_cipher_finish()

Browse source
This commit is contained in:
Janos Follath 2018-07-09 16:04:51 +01:00 committed by itayzafrir
parent 25c4fa8fb0
commit 315b51c22d
1 changed files with 31 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
library/psa_crypto.c
View file

@ -2410,18 +2410,19 @@ psa_status_t psa_cipher_finish( psa_cipher_operation_t *operation,
size_t output_size, size_t output_size,
size_t *output_length ) size_t *output_length )
{ {
int ret = MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE; psa_status_t status = PSA_ERROR_UNKNOWN_ERROR;
int cipher_ret = MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE;
uint8_t temp_output_buffer[MBEDTLS_MAX_BLOCK_LENGTH]; uint8_t temp_output_buffer[MBEDTLS_MAX_BLOCK_LENGTH];
if( ! operation->key_set ) if( ! operation->key_set )
{ {
psa_cipher_abort( operation ); status = PSA_ERROR_BAD_STATE;
return( PSA_ERROR_BAD_STATE ); goto error;
} }
if( operation->iv_required && ! operation->iv_set ) if( operation->iv_required && ! operation->iv_set )
{ {
psa_cipher_abort( operation ); status = PSA_ERROR_BAD_STATE;
return( PSA_ERROR_BAD_STATE ); goto error;
} }
if( operation->ctx.cipher.operation == MBEDTLS_ENCRYPT && if( operation->ctx.cipher.operation == MBEDTLS_ENCRYPT &&
PSA_ALG_IS_BLOCK_CIPHER( operation->alg ) ) PSA_ALG_IS_BLOCK_CIPHER( operation->alg ) )
@ -2430,37 +2431,49 @@ psa_status_t psa_cipher_finish( psa_cipher_operation_t *operation,
operation->alg & PSA_ALG_BLOCK_CIPHER_PADDING_MASK; operation->alg & PSA_ALG_BLOCK_CIPHER_PADDING_MASK;
if( operation->ctx.cipher.unprocessed_len >= operation->block_size ) if( operation->ctx.cipher.unprocessed_len >= operation->block_size )
{ {
psa_cipher_abort( operation ); status = PSA_ERROR_TAMPERING_DETECTED;
return( PSA_ERROR_TAMPERING_DETECTED ); goto error;
} }
if( padding_mode == PSA_ALG_BLOCK_CIPHER_PAD_NONE ) if( padding_mode == PSA_ALG_BLOCK_CIPHER_PAD_NONE )
{ {
if( operation->ctx.cipher.unprocessed_len != 0 ) if( operation->ctx.cipher.unprocessed_len != 0 )
{ {
psa_cipher_abort( operation ); status = PSA_ERROR_INVALID_ARGUMENT;
return( PSA_ERROR_INVALID_ARGUMENT ); goto error;
} }
} }
} }
ret = mbedtls_cipher_finish( &operation->ctx.cipher, temp_output_buffer, cipher_ret = mbedtls_cipher_finish( &operation->ctx.cipher,
output_length ); temp_output_buffer,
if( ret != 0 ) output_length );
if( cipher_ret != 0 )
{ {
psa_cipher_abort( operation ); status = mbedtls_to_psa_error( cipher_ret );
return( mbedtls_to_psa_error( ret ) ); goto error;
} }
if( *output_length == 0 ) if( *output_length == 0 )
/* Nothing to copy. Note that output may be NULL in this case. */ ; ; /* Nothing to copy. Note that output may be NULL in this case. */
else if( output_size >= *output_length ) else if( output_size >= *output_length )
memcpy( output, temp_output_buffer, *output_length ); memcpy( output, temp_output_buffer, *output_length );
else else
{ {
psa_cipher_abort( operation ); status = PSA_ERROR_BUFFER_TOO_SMALL;
return( PSA_ERROR_BUFFER_TOO_SMALL ); goto error;
} }
return( PSA_SUCCESS ); status = psa_cipher_abort( operation );
return( status );
error:
*output_length = 0;
(void) psa_cipher_abort( operation );
return( status );
} }
psa_status_t psa_cipher_abort( psa_cipher_operation_t *operation ) psa_status_t psa_cipher_abort( psa_cipher_operation_t *operation )