yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-06-01 16:20:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5741 from gilles-peskine-arm/depends-curves-positive-only-2.28

Browse source 
Backport 2.28: Don't test with all-but-one elliptic curves
This commit is contained in:
Gilles Peskine 2022-04-21 12:34:47 +02:00 committed by GitHub
parent f7a101af3c 2f8b09c725
commit 35de7b013a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
tests/scripts/curves.pl
View file

@ -20,18 +20,24 @@
# Purpose # Purpose
# #
# The purpose of this test script is to validate that the library works # The purpose of this test script is to validate that the library works
# with any combination of elliptic curves. To this effect, build the library # when only a single curve is enabled. In particular, this validates that
# and run the test suite with each tested combination of elliptic curves. # curve-specific code is guarded by the proper preprocessor conditionals,
# both in the library and in tests.
# #
# Testing all 2^n combinations would be too much, so we only test 2*n: # Since this script only tests builds with a single curve, it can't detect
# bugs that are only triggered when multiple curves are present. We do
# also test in many configurations where all curves are enabled, as well
# as a few configurations in configs/*.h with a restricted subset of curves.
# #
# 1. Test with a single curve, for each curve. This validates that the # Here are some known test gaps that could be addressed by testing all
# library works with any curve, and in particular that curve-specific # 2^n combinations of support for n curves, which is impractical:
# code is guarded by the proper preprocessor conditionals. # * There could be product bugs when curves A and B are enabled but not C.
# 2. Test with all curves except one, for each curve. This validates that # For example, a MAX_SIZE calculation that forgets B, where
# the test cases have correct dependencies. Testing with a single curve # size(A) < size(B) < size(C).
# doesn't validate this for tests that require more than one curve. # * For test cases that require three or more curves, validate that they're
# not missing dependencies. This is extremely rare. (For test cases that
# require curves A and B but are missing a dependency on B, this is
# detected in the A-only build.)
# Usage: tests/scripts/curves.pl # Usage: tests/scripts/curves.pl
# #
# This script should be executed from the root of the project directory. # This script should be executed from the root of the project directory.
@ -114,31 +120,6 @@ for my $curve (@curves) {
and abort "Failed to disable $curve\n"; and abort "Failed to disable $curve\n";
} }
system( "cp $config_h.bak $config_h" ) and die "$config_h not restored\n";
# Test with $curve disabled but the others enabled, for each $curve.
for my $curve (@curves) {
system( "cp $config_h.bak $config_h" ) and die "$config_h not restored\n";
system( "make clean" ) and die;
# depends on a specific curve. Also, ignore error if it wasn't enabled
system( "scripts/config.py unset MBEDTLS_KEY_EXCHANGE_ECJPAKE_ENABLED" );
print "\n******************************************\n";
print "* Testing without curve: $curve\n";
print "******************************************\n";
$ENV{MBEDTLS_TEST_CONFIGURATION} = "-$curve";
system( "scripts/config.py unset $curve" )
and abort "Failed to disable $curve\n";
system( "CFLAGS='-Werror -Wall -Wextra' make" )
and abort "Failed to build: all but $curve\n";
system( "make test" )
and abort "Failed test suite: all but $curve\n";
}
system( "mv $config_h.bak $config_h" ) and die "$config_h not restored\n"; system( "mv $config_h.bak $config_h" ) and die "$config_h not restored\n";
system( "make clean" ) and die; system( "make clean" ) and die;
exit 0; exit 0;