Documentation error in mbedtls_ssl_get_session

Fix Documentation error in `mbedtls_ssl_get_session`.
This function supports deep copying of the session,
and the peer certificate is not lost anymore, Resolves #926
This commit is contained in:
Ron Eldor 2017-05-17 18:59:53 +03:00
parent 88e414f4b7
commit 4624030dc4
2 changed files with 12 additions and 1 deletions

View file

@ -1,5 +1,12 @@
mbed TLS ChangeLog (Sorted per branch, date) mbed TLS ChangeLog (Sorted per branch, date)
= mbed TLS x.x.x branch released xxxx-xx-xx
Bugfix
* Remove wrong documentation for `mbedtls_ssl_get_session`.
This API has deep copy of the session, and the peer
certificate is not lost. #926
= mbed TLS 2.7.4 branch released 2018-06-18 = mbed TLS 2.7.4 branch released 2018-06-18
Bugfix Bugfix

View file

@ -2370,7 +2370,6 @@ const mbedtls_x509_crt *mbedtls_ssl_get_peer_cert( const mbedtls_ssl_context *ss
* \brief Save session in order to resume it later (client-side only) * \brief Save session in order to resume it later (client-side only)
* Session data is copied to presented session structure. * Session data is copied to presented session structure.
* *
* \warning Currently, peer certificate is lost in the operation.
* *
* \param ssl SSL context * \param ssl SSL context
* \param session session context * \param session session context
@ -2380,6 +2379,11 @@ const mbedtls_x509_crt *mbedtls_ssl_get_peer_cert( const mbedtls_ssl_context *ss
* MBEDTLS_ERR_SSL_BAD_INPUT_DATA if used server-side or * MBEDTLS_ERR_SSL_BAD_INPUT_DATA if used server-side or
* arguments are otherwise invalid * arguments are otherwise invalid
* *
* \note Only the server certificate is copied, and not the chain
* but this is not a problem because the result of the chain
* verification is stored in `verify_result` and can be checked
* with \c mbedtls_ssl_get_verify_result()
*
* \sa mbedtls_ssl_set_session() * \sa mbedtls_ssl_set_session()
*/ */
int mbedtls_ssl_get_session( const mbedtls_ssl_context *ssl, mbedtls_ssl_session *session ); int mbedtls_ssl_get_session( const mbedtls_ssl_context *ssl, mbedtls_ssl_session *session );