yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-02-02 18:01:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Test PSA functions against PSA_SUCCESS, not 0

Browse source 
Writing 0 instead of PSA_SUCCESS is correct, but bad form.
This commit is contained in:
Gilles Peskine 2019-06-07 15:39:07 +02:00
parent 69c0ea26c7
commit 614faa26ac
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/suites/test_suite_cipher.function
View file

@ -982,7 +982,7 @@ void auth_crypt_tv( int cipher_id, data_t * key, data_t * iv,
#else #else
if( use_psa == 1 ) if( use_psa == 1 )
{ {
TEST_ASSERT( psa_crypto_init() == 0 ); TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
/* PSA requires that the tag immediately follows the ciphertext. */ /* PSA requires that the tag immediately follows the ciphertext. */
tmp_cipher = mbedtls_calloc( 1, cipher->len + tag->len ); tmp_cipher = mbedtls_calloc( 1, cipher->len + tag->len );
@ -1143,7 +1143,7 @@ void test_vec_crypt( int cipher_id, int operation, char *hex_key,
#else #else
if( use_psa == 1 ) if( use_psa == 1 )
{ {
TEST_ASSERT( psa_crypto_init() == 0 ); TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
TEST_ASSERT( 0 == mbedtls_cipher_setup_psa( &ctx, TEST_ASSERT( 0 == mbedtls_cipher_setup_psa( &ctx,
mbedtls_cipher_info_from_type( cipher_id ), 0 ) ); mbedtls_cipher_info_from_type( cipher_id ), 0 ) );
} }

2
tests/suites/test_suite_pk.function
View file

@ -127,7 +127,7 @@ void pk_psa_utils( )
mbedtls_pk_init( &pk ); mbedtls_pk_init( &pk );
mbedtls_pk_init( &pk2 ); mbedtls_pk_init( &pk2 );
TEST_ASSERT( psa_crypto_init() == 0 ); TEST_ASSERT( psa_crypto_init( ) == PSA_SUCCESS );
TEST_ASSERT( mbedtls_pk_setup_opaque( &pk, 0 ) == TEST_ASSERT( mbedtls_pk_setup_opaque( &pk, 0 ) ==
MBEDTLS_ERR_PK_BAD_INPUT_DATA ); MBEDTLS_ERR_PK_BAD_INPUT_DATA );