yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-03-26 20:25:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix documentation for mbedtls_gcm_finish()

Browse source 
Fix implementation and documentation missmatch for the function
arguments to mbedtls_gcm_finish(). Also, removed redundant if condition
that always evaluates to true.
This commit is contained in:
Andres AG 2016-09-26 10:09:30 +01:00 committed by Simon Butcher
parent 6b8d9cffc2
commit 6ad5d9450a
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -23,6 +23,8 @@ Bugfix
* Fixed the sample applications gen_key.c, cert_req.c and cert_write.c for * Fixed the sample applications gen_key.c, cert_req.c and cert_write.c for
builds where the configuration POLARSSL_PEM_WRITE_C is not defined. Found builds where the configuration POLARSSL_PEM_WRITE_C is not defined. Found
by inestlerode. #559. by inestlerode. #559.
* Fix documentation and implementation missmatch for function arguments of
mbedtls_gcm_finish(). Found by cmiatpaar.
Changes Changes
* Add compile time option for relaxed X509 time verification to enable * Add compile time option for relaxed X509 time verification to enable

4
include/polarssl/gcm.h
View file

@ -186,8 +186,8 @@ int gcm_update( gcm_context *ctx,
* 16 bytes. * 16 bytes.
* *
* \param ctx GCM context * \param ctx GCM context
* \param tag buffer for holding the tag (may be NULL if tag_len is 0) * \param tag buffer for holding the tag
* \param tag_len length of the tag to generate * \param tag_len length of the tag to generate (must be at least 4)
* *
* \return 0 if successful or POLARSSL_ERR_GCM_BAD_INPUT * \return 0 if successful or POLARSSL_ERR_GCM_BAD_INPUT
*/ */

1
library/gcm.c
View file

@ -410,7 +410,6 @@ int gcm_finish( gcm_context *ctx,
if( tag_len > 16 || tag_len < 4 ) if( tag_len > 16 || tag_len < 4 )
return( POLARSSL_ERR_GCM_BAD_INPUT ); return( POLARSSL_ERR_GCM_BAD_INPUT );
if( tag_len != 0 )
memcpy( tag, ctx->base_ectr, tag_len ); memcpy( tag, ctx->base_ectr, tag_len );
if( orig_len || orig_add_len ) if( orig_len || orig_add_len )