Review corrections

-Fix compiler warnings by typecast
 -Add missing brackets to few places
 -Remove additional line change
This commit is contained in:
Arto Kinnunen 2019-09-06 17:37:01 +03:00
parent ee9bfca823
commit 6e3f09b431
3 changed files with 6 additions and 6 deletions

View file

@ -700,7 +700,7 @@ static int ssl_generate_random( mbedtls_ssl_context *ssl )
#if defined(MBEDTLS_HAVE_TIME) #if defined(MBEDTLS_HAVE_TIME)
t = mbedtls_time( NULL ); t = mbedtls_time( NULL );
p = mbedtls_platform_put_uint32_be( p, t ); p = mbedtls_platform_put_uint32_be( p, (uint32_t) t );
MBEDTLS_SSL_DEBUG_MSG( 3, ( "client hello, current time: %lu", t ) ); MBEDTLS_SSL_DEBUG_MSG( 3, ( "client hello, current time: %lu", t ) );
#else #else
if( ( ret = mbedtls_ssl_conf_get_frng( ssl->conf ) if( ( ret = mbedtls_ssl_conf_get_frng( ssl->conf )

View file

@ -2774,7 +2774,7 @@ static int ssl_write_server_hello( mbedtls_ssl_context *ssl )
#if defined(MBEDTLS_HAVE_TIME) #if defined(MBEDTLS_HAVE_TIME)
t = mbedtls_time( NULL ); t = mbedtls_time( NULL );
p = mbedtls_platform_put_uint32_be( p, t ); p = mbedtls_platform_put_uint32_be( p, (uint32_t) t );
MBEDTLS_SSL_DEBUG_MSG( 3, ( "server hello, current time: %lu", t ) ); MBEDTLS_SSL_DEBUG_MSG( 3, ( "server hello, current time: %lu", t ) );
#else #else

View file

@ -2236,7 +2236,7 @@ static void ssl_mac( mbedtls_md_context_t *md_ctx,
padlen = 40; padlen = 40;
memcpy( header, ctr, 8 ); memcpy( header, ctr, 8 );
header[ 8] = (unsigned char) type; header[8] = (unsigned char) type;
mbedtls_platform_put_uint16_be( &header[9], len ); mbedtls_platform_put_uint16_be( &header[9], len );
memset( padding, 0x36, padlen ); memset( padding, 0x36, padlen );
@ -4624,12 +4624,12 @@ static int ssl_hs_is_proper_fragment( mbedtls_ssl_context *ssl )
static uint32_t ssl_get_hs_frag_len( mbedtls_ssl_context const *ssl ) static uint32_t ssl_get_hs_frag_len( mbedtls_ssl_context const *ssl )
{ {
return mbedtls_platform_get_uint24_be( &ssl->in_msg[9] ); return ( mbedtls_platform_get_uint24_be( &ssl->in_msg[9] ) );
} }
static uint32_t ssl_get_hs_frag_off( mbedtls_ssl_context const *ssl ) static uint32_t ssl_get_hs_frag_off( mbedtls_ssl_context const *ssl )
{ {
return mbedtls_platform_get_uint24_be( &ssl->in_msg[6] ); return ( mbedtls_platform_get_uint24_be( &ssl->in_msg[6] ) );
} }
static int ssl_check_hs_header( mbedtls_ssl_context const *ssl ) static int ssl_check_hs_header( mbedtls_ssl_context const *ssl )
@ -4732,7 +4732,7 @@ static size_t ssl_get_reassembly_buffer_size( size_t msg_len,
static uint32_t ssl_get_hs_total_len( mbedtls_ssl_context const *ssl ) static uint32_t ssl_get_hs_total_len( mbedtls_ssl_context const *ssl )
{ {
return mbedtls_platform_get_uint24_be( &ssl->in_msg[1] ); return ( mbedtls_platform_get_uint24_be( &ssl->in_msg[1] ) );
} }
int mbedtls_ssl_prepare_handshake_record( mbedtls_ssl_context *ssl ) int mbedtls_ssl_prepare_handshake_record( mbedtls_ssl_context *ssl )