yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-01-27 04:01:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

RSA: wipe more stack buffers

Browse source 
MGF mask and PSS salt are not highly sensitive, but wipe them anyway
for good hygiene.
This commit is contained in:
Gilles Peskine 2017-05-05 19:24:06 +02:00 committed by Simon Butcher
parent 213aec8688
commit 73e7f4c0ee
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
library/rsa.c
View file

@ -492,6 +492,8 @@ static void mgf_mask( unsigned char *dst, size_t dlen, unsigned char *src,
dlen -= use_len; dlen -= use_len;
} }
polarssl_zeroize( mask, sizeof( mask ) );
} }
#endif /* POLARSSL_PKCS1_V21 */ #endif /* POLARSSL_PKCS1_V21 */
@ -1011,6 +1013,7 @@ int rsa_rsassa_pss_sign( rsa_context *ctx,
if( ( ret = md_init_ctx( &md_ctx, md_info ) ) != 0 ) if( ( ret = md_init_ctx( &md_ctx, md_info ) ) != 0 )
{ {
md_free( &md_ctx ); md_free( &md_ctx );
/* No need to zeroize salt: we didn't use it. */
return( ret ); return( ret );
} }
@ -1021,6 +1024,7 @@ int rsa_rsassa_pss_sign( rsa_context *ctx,
md_update( &md_ctx, hash, hashlen ); md_update( &md_ctx, hash, hashlen );
md_update( &md_ctx, salt, slen ); md_update( &md_ctx, salt, slen );
md_finish( &md_ctx, p ); md_finish( &md_ctx, p );
polarssl_zeroize( salt, sizeof( salt ) );
// Compensate for boundary condition when applying mask // Compensate for boundary condition when applying mask
// //