Clarify some comments

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2021-08-02 23:14:03 +02:00 committed by Thomas Daubney
parent ef64e7fb3b
commit cb4bfac119

View file

@ -2873,8 +2873,11 @@ pseudo_component_error_test () {
echo "Expect three failing commands."
fi
error_test='this should not be used since the component runs in a subshell'
# Expected error: 'grep non_existent /dev/null -> 1'
grep non_existent /dev/null
# Expected error: '! grep -q . tests/scripts/all.sh -> 1'
not grep -q . "$0"
# Expected error: 'make unknown_target -> 2'
make unknown_target
false "this should not be executed"
}
@ -2894,8 +2897,11 @@ run_component () {
esac
"${dd_cmd[@]}"
# Run the component in a subshell
# Run the component in a subshell, with error trapping and output
# redirection set up based on the relevant options.
if [ $KEEP_GOING -eq 1 ]; then
# We want to keep running if the subshell fails, so 'set -e' must
# be off when the subshell runs.
set +e
fi
(