yuzu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2025-06-19 16:58:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add loop integrity check to curve param check

Browse source 
Also make the reference result static const while at it.
This commit is contained in:
Manuel Pégourié-Gonnard 2019-11-28 12:21:34 +01:00
parent 5c3066a4f6
commit e1cb8846e7
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tinycrypt/ecc.c
View file

@ -147,14 +147,14 @@ exit:
static int uECC_check_curve_integrity(void) static int uECC_check_curve_integrity(void)
{ {
unsigned char computed[32]; unsigned char computed[32];
unsigned char reference[32] = { static const unsigned char reference[32] = {
0x2d, 0xa1, 0xa4, 0x64, 0x45, 0x28, 0x0d, 0xe1, 0x2d, 0xa1, 0xa4, 0x64, 0x45, 0x28, 0x0d, 0xe1,
0x93, 0xf9, 0x29, 0x2f, 0xac, 0x3e, 0xe2, 0x92, 0x93, 0xf9, 0x29, 0x2f, 0xac, 0x3e, 0xe2, 0x92,
0x76, 0x0a, 0xe2, 0xbc, 0xce, 0x2a, 0xa2, 0xc6, 0x76, 0x0a, 0xe2, 0xbc, 0xce, 0x2a, 0xa2, 0xc6,
0x38, 0xf2, 0x19, 0x1d, 0x76, 0x72, 0x93, 0x49, 0x38, 0xf2, 0x19, 0x1d, 0x76, 0x72, 0x93, 0x49,
}; };
volatile unsigned char diff = 0; volatile unsigned char diff = 0;
unsigned char i; volatile unsigned i;
if (uECC_compute_param_sha256(computed) != UECC_SUCCESS) { if (uECC_compute_param_sha256(computed) != UECC_SUCCESS) {
return UECC_FAILURE; return UECC_FAILURE;
@ -163,6 +163,10 @@ static int uECC_check_curve_integrity(void)
for (i = 0; i < 32; i++) for (i = 0; i < 32; i++)
diff |= computed[i] ^ reference[i]; diff |= computed[i] ^ reference[i];
/* i should be 32 */
mbedtls_platform_enforce_volatile_reads();
diff |= (unsigned char) i ^ 32;
return diff; return diff;
} }