2015-08-21 07:04:50 +00:00
|
|
|
/*
|
|
|
|
* QEMU Machine
|
|
|
|
*
|
|
|
|
* Copyright (C) 2014 Red Hat Inc
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
|
|
* See the COPYING file in the top-level directory.
|
|
|
|
*/
|
|
|
|
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Backports commit da34e65cb4025728566d6504a99916f6e7e1dd6a from qemu
2018-02-22 04:05:15 +00:00
|
|
|
#include "qemu/osdep.h"
|
2015-08-21 07:04:50 +00:00
|
|
|
#include "hw/boards.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Backports commit da34e65cb4025728566d6504a99916f6e7e1dd6a from qemu
2018-02-22 04:05:15 +00:00
|
|
|
#include "qapi/error.h"
|
2018-02-22 14:24:12 +00:00
|
|
|
#include "qemu/cutils.h"
|
2015-08-21 07:04:50 +00:00
|
|
|
|
2018-03-11 18:29:19 +00:00
|
|
|
static void machine_class_base_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
if (!object_class_is_abstract(oc)) {
|
|
|
|
const char *cname = object_class_get_name(oc);
|
|
|
|
assert(g_str_has_suffix(cname, TYPE_MACHINE_SUFFIX));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-21 07:04:50 +00:00
|
|
|
static void machine_initfn(struct uc_struct *uc, Object *obj, void *opaque)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static void machine_finalize(struct uc_struct *uc, Object *obj, void *opaque)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo machine_info = {
|
2017-01-20 06:27:22 +00:00
|
|
|
TYPE_MACHINE,
|
|
|
|
TYPE_OBJECT,
|
2017-01-22 13:27:17 +00:00
|
|
|
|
2017-01-20 06:27:22 +00:00
|
|
|
sizeof(MachineClass),
|
|
|
|
sizeof(MachineState),
|
2017-01-21 01:28:22 +00:00
|
|
|
NULL,
|
2017-01-20 06:27:22 +00:00
|
|
|
|
|
|
|
machine_initfn,
|
2017-01-21 01:28:22 +00:00
|
|
|
NULL,
|
2017-01-20 06:27:22 +00:00
|
|
|
machine_finalize,
|
2017-01-22 13:27:17 +00:00
|
|
|
|
2017-01-21 01:28:22 +00:00
|
|
|
NULL,
|
2017-01-20 06:27:22 +00:00
|
|
|
|
2017-01-21 01:28:22 +00:00
|
|
|
NULL,
|
2018-03-11 18:29:19 +00:00
|
|
|
machine_class_base_init,
|
2017-01-21 01:28:22 +00:00
|
|
|
NULL,
|
2017-01-20 06:27:22 +00:00
|
|
|
|
2017-01-21 01:28:22 +00:00
|
|
|
true,
|
2015-08-21 07:04:50 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
void machine_register_types(struct uc_struct *uc)
|
|
|
|
{
|
|
|
|
type_register_static(uc, &machine_info);
|
|
|
|
}
|