yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-07-23 00:28:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

target/arm: Refactor disas_simd_indexed decode

Browse source 
Include the U bit in the switches rather than testing separately.

Backports commit 5f81b1de43259ed0969e62a7419ab9dd9da2c5c0 from qemu
This commit is contained in:
Richard Henderson 2018-03-08 23:32:41 -05:00 committed by Lioncash
parent 109a777fd6
commit 1fd2644738
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
1 changed files with 61 additions and 68 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

129
qemu/target/arm/translate-a64.c
View file

@ -11941,49 +11941,39 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
int index; int index;
TCGv_ptr fpst; TCGv_ptr fpst;
switch (opcode) { switch (16 * u + opcode) {
case 0x0: /* MLA */ case 0x08: /* MUL */
case 0x4: /* MLS */ case 0x10: /* MLA */
if (!u || is_scalar) { case 0x14: /* MLS */
if (is_scalar) {
unallocated_encoding(s); unallocated_encoding(s);
return; return;
} }
break; break;
case 0x2: /* SMLAL, SMLAL2, UMLAL, UMLAL2 */ case 0x02: /* SMLAL, SMLAL2 */
case 0x6: /* SMLSL, SMLSL2, UMLSL, UMLSL2 */ case 0x12: /* UMLAL, UMLAL2 */
case 0xa: /* SMULL, SMULL2, UMULL, UMULL2 */ case 0x06: /* SMLSL, SMLSL2 */
case 0x16: /* UMLSL, UMLSL2 */
case 0x0a: /* SMULL, SMULL2 */
case 0x1a: /* UMULL, UMULL2 */
if (is_scalar) { if (is_scalar) {
unallocated_encoding(s); unallocated_encoding(s);
return; return;
} }
is_long = true; is_long = true;
break; break;
case 0x3: /* SQDMLAL, SQDMLAL2 */ case 0x03: /* SQDMLAL, SQDMLAL2 */
case 0x7: /* SQDMLSL, SQDMLSL2 */ case 0x07: /* SQDMLSL, SQDMLSL2 */
case 0xb: /* SQDMULL, SQDMULL2 */ case 0x0b: /* SQDMULL, SQDMULL2 */
is_long = true; is_long = true;
/* fall through */
case 0xc: /* SQDMULH */
case 0xd: /* SQRDMULH */
if (u) {
unallocated_encoding(s);
return;
}
break; break;
case 0x8: /* MUL */ case 0x0c: /* SQDMULH */
if (u || is_scalar) { case 0x0d: /* SQRDMULH */
unallocated_encoding(s);
return;
}
break; break;
case 0x1: /* FMLA */ case 0x01: /* FMLA */
case 0x5: /* FMLS */ case 0x05: /* FMLS */
if (u) { case 0x09: /* FMUL */
unallocated_encoding(s); case 0x19: /* FMULX */
return;
}
/* fall through */
case 0x9: /* FMUL, FMULX */
if (size == 1) { if (size == 1) {
unallocated_encoding(s); unallocated_encoding(s);
return; return;
@ -12063,21 +12053,20 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
read_vec_element(s, tcg_op, rn, pass, MO_64); read_vec_element(s, tcg_op, rn, pass, MO_64);
switch (opcode) { switch (16 * u + opcode) {
case 0x5: /* FMLS */ case 0x05: /* FMLS */
/* As usual for ARM, separate negation for fused multiply-add */ /* As usual for ARM, separate negation for fused multiply-add */
gen_helper_vfp_negd(tcg_ctx, tcg_op, tcg_op); gen_helper_vfp_negd(tcg_ctx, tcg_op, tcg_op);
/* fall through */ /* fall through */
case 0x1: /* FMLA */ case 0x01: /* FMLA */
read_vec_element(s, tcg_res, rd, pass, MO_64); read_vec_element(s, tcg_res, rd, pass, MO_64);
gen_helper_vfp_muladdd(tcg_ctx, tcg_res, tcg_op, tcg_idx, tcg_res, fpst); gen_helper_vfp_muladdd(tcg_ctx, tcg_res, tcg_op, tcg_idx, tcg_res, fpst);
break; break;
case 0x9: /* FMUL, FMULX */ case 0x09: /* FMUL */
if (u) { gen_helper_vfp_muld(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
gen_helper_vfp_mulxd(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst); break;
} else { case 0x19: /* FMULX */
gen_helper_vfp_muld(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst); gen_helper_vfp_mulxd(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
}
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();
@ -12120,10 +12109,10 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
read_vec_element_i32(s, tcg_op, rn, pass, is_scalar ? size : MO_32); read_vec_element_i32(s, tcg_op, rn, pass, is_scalar ? size : MO_32);
switch (opcode) { switch (16 * u + opcode) {
case 0x0: /* MLA */ case 0x08: /* MUL */
case 0x4: /* MLS */ case 0x10: /* MLA */
case 0x8: /* MUL */ case 0x14: /* MLS */
{ {
static NeonGenTwoOpFn * const fns[2][2] = { static NeonGenTwoOpFn * const fns[2][2] = {
{ gen_helper_neon_add_u16, gen_helper_neon_sub_u16 }, { gen_helper_neon_add_u16, gen_helper_neon_sub_u16 },
@ -12145,8 +12134,8 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
genfn(tcg_ctx, tcg_res, tcg_op, tcg_res); genfn(tcg_ctx, tcg_res, tcg_op, tcg_res);
break; break;
} }
case 0x5: /* FMLS */ case 0x05: /* FMLS */
case 0x1: /* FMLA */ case 0x01: /* FMLA */
read_vec_element_i32(s, tcg_res, rd, pass, read_vec_element_i32(s, tcg_res, rd, pass,
is_scalar ? size : MO_32); is_scalar ? size : MO_32);
switch (size) { switch (size) {
@ -12177,39 +12166,43 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
g_assert_not_reached(); g_assert_not_reached();
} }
break; break;
case 0x9: /* FMUL, FMULX */ case 0x09: /* FMUL */
switch (size) { switch (size) {
case 1: case 1:
if (u) { if (is_scalar) {
if (is_scalar) { gen_helper_advsimd_mulh(tcg_ctx, tcg_res, tcg_op,
gen_helper_advsimd_mulxh(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
tcg_idx, fpst);
} else {
gen_helper_advsimd_mulx2h(tcg_ctx, tcg_res, tcg_op,
tcg_idx, fpst);
}
} else { } else {
if (is_scalar) { gen_helper_advsimd_mul2h(tcg_ctx, tcg_res, tcg_op,
gen_helper_advsimd_mulh(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
tcg_idx, fpst);
} else {
gen_helper_advsimd_mul2h(tcg_ctx, tcg_res, tcg_op,
tcg_idx, fpst);
}
} }
break; break;
case 2: case 2:
if (u) { gen_helper_vfp_muls(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
gen_helper_vfp_mulxs(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
} else {
gen_helper_vfp_muls(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
}
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();
} }
break; break;
case 0xc: /* SQDMULH */ case 0x19: /* FMULX */
switch (size) {
case 1:
if (is_scalar) {
gen_helper_advsimd_mulxh(tcg_ctx, tcg_res, tcg_op,
tcg_idx, fpst);
} else {
gen_helper_advsimd_mulx2h(tcg_ctx, tcg_res, tcg_op,
tcg_idx, fpst);
}
break;
case 2:
gen_helper_vfp_mulxs(tcg_ctx, tcg_res, tcg_op, tcg_idx, fpst);
break;
default:
g_assert_not_reached();
}
break;
case 0x0c: /* SQDMULH */
if (size == 1) { if (size == 1) {
gen_helper_neon_qdmulh_s16(tcg_ctx, tcg_res, tcg_ctx->cpu_env, gen_helper_neon_qdmulh_s16(tcg_ctx, tcg_res, tcg_ctx->cpu_env,
tcg_op, tcg_idx); tcg_op, tcg_idx);
@ -12218,7 +12211,7 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
tcg_op, tcg_idx); tcg_op, tcg_idx);
} }
break; break;
case 0xd: /* SQRDMULH */ case 0x0d: /* SQRDMULH */
if (size == 1) { if (size == 1) {
gen_helper_neon_qrdmulh_s16(tcg_ctx, tcg_res, tcg_ctx->cpu_env, gen_helper_neon_qrdmulh_s16(tcg_ctx, tcg_res, tcg_ctx->cpu_env,
tcg_op, tcg_idx); tcg_op, tcg_idx);