yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-07-17 18:57:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

target/arm: Use arm_hcr_el2_eff more places

Browse source 
Since arm_hcr_el2_eff includes a check against
arm_is_secure_below_el3, we can often remove a
nearby check against secure state.

In some cases, sort the call to arm_hcr_el2_eff
to the end of a short-circuit logical sequence.

Backports commit 7c208e0f4171c9e2cc35efc12e1bf264a45c229f from qemu
This commit is contained in:
Richard Henderson 2018-12-18 04:32:44 -05:00 committed by Lioncash
parent 78798d10eb
commit 32208e482b
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
2 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
qemu/target/arm/helper.c
View file

@ -322,7 +322,7 @@ static CPAccessResult access_tdosa(CPUARMState *env, const ARMCPRegInfo *ri,
int el = arm_current_el(env); int el = arm_current_el(env);
bool mdcr_el2_tdosa = (env->cp15.mdcr_el2 & MDCR_TDOSA) || bool mdcr_el2_tdosa = (env->cp15.mdcr_el2 & MDCR_TDOSA) ||
(env->cp15.mdcr_el2 & MDCR_TDE) || (env->cp15.mdcr_el2 & MDCR_TDE) ||
(env->cp15.hcr_el2 & HCR_TGE); (arm_hcr_el2_eff(env) & HCR_TGE);
if (el < 2 && mdcr_el2_tdosa && !arm_is_secure_below_el3(env)) { if (el < 2 && mdcr_el2_tdosa && !arm_is_secure_below_el3(env)) {
return CP_ACCESS_TRAP_EL2; return CP_ACCESS_TRAP_EL2;
@ -342,7 +342,7 @@ static CPAccessResult access_tdra(CPUARMState *env, const ARMCPRegInfo *ri,
int el = arm_current_el(env); int el = arm_current_el(env);
bool mdcr_el2_tdra = (env->cp15.mdcr_el2 & MDCR_TDRA) || bool mdcr_el2_tdra = (env->cp15.mdcr_el2 & MDCR_TDRA) ||
(env->cp15.mdcr_el2 & MDCR_TDE) || (env->cp15.mdcr_el2 & MDCR_TDE) ||
(env->cp15.hcr_el2 & HCR_TGE); (arm_hcr_el2_eff(env) & HCR_TGE);
if (el < 2 && mdcr_el2_tdra && !arm_is_secure_below_el3(env)) { if (el < 2 && mdcr_el2_tdra && !arm_is_secure_below_el3(env)) {
return CP_ACCESS_TRAP_EL2; return CP_ACCESS_TRAP_EL2;
@ -362,7 +362,7 @@ static CPAccessResult access_tda(CPUARMState *env, const ARMCPRegInfo *ri,
int el = arm_current_el(env); int el = arm_current_el(env);
bool mdcr_el2_tda = (env->cp15.mdcr_el2 & MDCR_TDA) || bool mdcr_el2_tda = (env->cp15.mdcr_el2 & MDCR_TDA) ||
(env->cp15.mdcr_el2 & MDCR_TDE) || (env->cp15.mdcr_el2 & MDCR_TDE) ||
(env->cp15.hcr_el2 & HCR_TGE); (arm_hcr_el2_eff(env) & HCR_TGE);
if (el < 2 && mdcr_el2_tda && !arm_is_secure_below_el3(env)) { if (el < 2 && mdcr_el2_tda && !arm_is_secure_below_el3(env)) {
return CP_ACCESS_TRAP_EL2; return CP_ACCESS_TRAP_EL2;
@ -3988,8 +3988,7 @@ int sve_exception_el(CPUARMState *env, int el)
if (disabled) { if (disabled) {
/* route_to_el2 */ /* route_to_el2 */
return (arm_feature(env, ARM_FEATURE_EL2) return (arm_feature(env, ARM_FEATURE_EL2)
&& !arm_is_secure(env) && (arm_hcr_el2_eff(env) & HCR_TGE) ? 2 : 1);
&& (env->cp15.hcr_el2 & HCR_TGE) ? 2 : 1);
} }
/* Check CPACR.FPEN. */ /* Check CPACR.FPEN. */
@ -5398,9 +5397,8 @@ static int bad_mode_switch(CPUARMState *env, int mode, CPSRWriteType write_type)
* and CPS are treated as illegal mode changes. * and CPS are treated as illegal mode changes.
*/ */
if (write_type == CPSRWriteByInstr && if (write_type == CPSRWriteByInstr &&
(env->cp15.hcr_el2 & HCR_TGE) &&
(env->uncached_cpsr & CPSR_M) == ARM_CPU_MODE_MON && (env->uncached_cpsr & CPSR_M) == ARM_CPU_MODE_MON &&
!arm_is_secure_below_el3(env)) { (arm_hcr_el2_eff(env) & HCR_TGE)) {
return 1; return 1;
} }
return 0; return 0;

14
qemu/target/arm/op_helper.c
View file

@ -32,8 +32,7 @@ void raise_exception(CPUARMState *env, uint32_t excp,
{ {
CPUState *cs = CPU(arm_env_get_cpu(env)); CPUState *cs = CPU(arm_env_get_cpu(env));
if ((env->cp15.hcr_el2 & HCR_TGE) && if (target_el == 1 && (arm_hcr_el2_eff(env) & HCR_TGE)) {
target_el == 1 && !arm_is_secure(env)) {
/* /*
* Redirect NS EL1 exceptions to NS EL2. These are reported with * Redirect NS EL1 exceptions to NS EL2. These are reported with
* their original syndrome register value, with the exception of * their original syndrome register value, with the exception of
@ -427,9 +426,9 @@ static inline int check_wfx_trap(CPUARMState *env, bool is_wfe)
* No need for ARM_FEATURE check as if HCR_EL2 doesn't exist the * No need for ARM_FEATURE check as if HCR_EL2 doesn't exist the
* bits will be zero indicating no trap. * bits will be zero indicating no trap.
*/ */
if (cur_el < 2 && !arm_is_secure(env)) { if (cur_el < 2) {
mask = (is_wfe) ? HCR_TWE : HCR_TWI; mask = is_wfe ? HCR_TWE : HCR_TWI;
if (env->cp15.hcr_el2 & mask) { if (arm_hcr_el2_eff(env) & mask) {
return 2; return 2;
} }
} }
@ -975,7 +974,7 @@ void HELPER(pre_smc)(CPUARMState *env, uint32_t syndrome)
exception_target_el(env)); exception_target_el(env));
} }
if (!secure && cur_el == 1 && (env->cp15.hcr_el2 & HCR_TSC)) { if (cur_el == 1 && (arm_hcr_el2_eff(env) & HCR_TSC)) {
/* In NS EL1, HCR controlled routing to EL2 has priority over SMD. /* In NS EL1, HCR controlled routing to EL2 has priority over SMD.
* We also want an EL2 guest to be able to forbid its EL1 from * We also want an EL2 guest to be able to forbid its EL1 from
* making PSCI calls into QEMU's "firmware" via HCR.TSC. * making PSCI calls into QEMU's "firmware" via HCR.TSC.
@ -1078,8 +1077,7 @@ void HELPER(exception_return)(CPUARMState *env)
goto illegal_return; goto illegal_return;
} }
if (new_el == 1 && (env->cp15.hcr_el2 & HCR_TGE) if (new_el == 1 && (arm_hcr_el2_eff(env) & HCR_TGE)) {
&& !arm_is_secure_below_el3(env)) {
goto illegal_return; goto illegal_return;
} }