yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2024-12-23 13:45:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

qapi: Consolidate visitor small integer callbacks

Browse source 
Commit 4e27e819 introduced optional visitor callbacks for all
sorts of int types, but no visitor has supplied any of the
callbacks for sizes less than 64 bits. In other words, the
generic implementation based on using type_[u]int64() followed
by bounds-checking works just fine. In the interest of
simplicity, it's easier to make the visitor callback interface
not have to worry about the other sizes.

Adding some helper functions minimizes the boilerplate required
to correct FIXMEs added earlier with regards to questionable
reuse of errp, particularly now that we can guarantee from a
single file audit that value is unchanged if an error is set.

Backports commit 04e070d217b4414f1f91aa8ad25fc0ae7ca0be93 from qemu
This commit is contained in:
Eric Blake 2018-02-19 23:20:01 -05:00 committed by Lioncash
parent 9ec25b4673
commit 4100f3b78a
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
2 changed files with 52 additions and 104 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
qemu/include/qapi/visitor-impl.h
View file

@ -55,12 +55,6 @@ struct Visitor
/* May be NULL; most useful for input visitors. */ /* May be NULL; most useful for input visitors. */
void (*optional)(Visitor *v, bool *present, const char *name); void (*optional)(Visitor *v, bool *present, const char *name);
void (*type_uint8)(Visitor *v, uint8_t *obj, const char *name, Error **errp);
void (*type_uint16)(Visitor *v, uint16_t *obj, const char *name, Error **errp);
void (*type_uint32)(Visitor *v, uint32_t *obj, const char *name, Error **errp);
void (*type_int8)(Visitor *v, int8_t *obj, const char *name, Error **errp);
void (*type_int16)(Visitor *v, int16_t *obj, const char *name, Error **errp);
void (*type_int32)(Visitor *v, int32_t *obj, const char *name, Error **errp);
bool (*start_union)(Visitor *v, bool data_present, Error **errp); bool (*start_union)(Visitor *v, bool data_present, Error **errp);
}; };

150
qemu/qapi/qapi-visit-core.c
View file

@ -97,67 +97,42 @@ void visit_type_int(Visitor *v, const char *name, int64_t *obj, Error **errp)
v->type_int64(v, obj, name, errp); v->type_int64(v, obj, name, errp);
} }
void visit_type_uint8(Visitor *v, const char *name, uint8_t *obj, static void visit_type_uintN(Visitor *v, uint64_t *obj, const char *name,
Error **errp) uint64_t max, const char *type, Error **errp)
{ {
uint64_t value; Error *err = NULL;
uint64_t value = *obj;
if (v->type_uint8) { v->type_uint64(v, &value, name, &err);
v->type_uint8(v, obj, name, errp); if (err) {
error_propagate(errp, err);
} else if (value > max) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", type);
} else { } else {
value = *obj; *obj = value;
v->type_uint64(v, &value, name, errp);
if (value > UINT8_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "uint8_t");
return;
}
*obj = (uint8_t)value;
} }
} }
void visit_type_uint16(Visitor *v, const char *name, uint16_t *obj, void visit_type_uint8(Visitor *v, const char *name, uint8_t *obj, Error **errp)
Error **errp)
{ {
uint64_t value; uint64_t value = *obj;
visit_type_uintN(v, &value, name, UINT8_MAX, "uint8_t", errp);
if (v->type_uint16) { *obj = value;
v->type_uint16(v, obj, name, errp);
} else {
value = *obj;
v->type_uint64(v, &value, name, errp);
if (value > UINT16_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "uint16_t");
return;
}
*obj = (uint16_t)value;
}
} }
void visit_type_uint32(Visitor *v, const char *name, uint32_t *obj, void visit_type_uint16(Visitor *v, const char *name, uint16_t *obj, Error **errp)
Error **errp)
{ {
uint64_t value; uint64_t value = *obj;
visit_type_uintN(v, &value, name, UINT16_MAX, "uint16_t", errp);
*obj = value;
}
if (v->type_uint32) { void visit_type_uint32(Visitor *v, const char *name, uint32_t *obj, Error **errp)
v->type_uint32(v, obj, name, errp); {
} else { uint64_t value = *obj;
value = *obj; visit_type_uintN(v, &value, name, UINT32_MAX, "uint32_t", errp);
v->type_uint64(v, &value, name, errp); *obj = value;
if (value > UINT32_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "uint32_t");
return;
}
*obj = (uint32_t)value;
}
} }
void visit_type_uint64(Visitor *v, const char *name, uint64_t *obj, void visit_type_uint64(Visitor *v, const char *name, uint64_t *obj,
@ -166,66 +141,45 @@ void visit_type_uint64(Visitor *v, const char *name, uint64_t *obj,
v->type_uint64(v, obj, name, errp); v->type_uint64(v, obj, name, errp);
} }
static void visit_type_intN(Visitor *v, int64_t *obj, const char *name,
int64_t min, int64_t max, const char *type,
Error **errp)
{
Error *err = NULL;
int64_t value = *obj;
v->type_int64(v, &value, name, &err);
if (err) {
error_propagate(errp, err);
} else if (value < min || value > max) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", type);
} else {
*obj = value;
}
}
void visit_type_int8(Visitor *v, const char *name, int8_t *obj, Error **errp) void visit_type_int8(Visitor *v, const char *name, int8_t *obj, Error **errp)
{ {
int64_t value; int64_t value = *obj;
visit_type_intN(v, &value, name, INT8_MIN, INT8_MAX, "int8_t", errp);
if (v->type_int8) { *obj = value;
v->type_int8(v, obj, name, errp);
} else {
value = *obj;
v->type_int64(v, &value, name, errp);
if (value < INT8_MIN || value > INT8_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "int8_t");
return;
}
*obj = (int8_t)value;
}
} }
void visit_type_int16(Visitor *v, const char *name, int16_t *obj, void visit_type_int16(Visitor *v, const char *name, int16_t *obj,
Error **errp) Error **errp)
{ {
int64_t value; int64_t value = *obj;
visit_type_intN(v, &value, name, INT16_MIN, INT16_MAX, "int16_t", errp);
if (v->type_int16) { *obj = value;
v->type_int16(v, obj, name, errp);
} else {
value = *obj;
v->type_int64(v, &value, name, errp);
if (value < INT16_MIN || value > INT16_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "int16_t");
return;
}
*obj = (int16_t)value;
}
} }
void visit_type_int32(Visitor *v, const char *name, int32_t *obj, void visit_type_int32(Visitor *v, const char *name, int32_t *obj,
Error **errp) Error **errp)
{ {
int64_t value; int64_t value = *obj;
visit_type_intN(v, &value, name, INT32_MIN, INT32_MAX, "int32_t", errp);
if (v->type_int32) { *obj = value;
v->type_int32(v, obj, name, errp);
} else {
value = *obj;
v->type_int64(v, &value, name, errp);
if (value < INT32_MIN || value > INT32_MAX) {
/* FIXME questionable reuse of errp if callback changed
value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", "int32_t");
return;
}
*obj = (int32_t)value;
}
} }
void visit_type_int64(Visitor *v, const char *name, int64_t *obj, void visit_type_int64(Visitor *v, const char *name, int64_t *obj,