yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-01-22 11:01:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

target/arm: Emit barriers for A32/T32 load-acquire/store-release insns

Browse source 
Now that MTTCG is here, the comment in the 32-bit Arm decoder that
"Since the emulation does not have barriers, the acquire/release
semantics need no special handling" is no longer true. Emit the
correct barriers for the load-acquire/store-release insns, as
we already do in the A64 decoder.

Backports commit 96c552958dbb63453b5f02bea6e704006d50e39a from qemu
This commit is contained in:
Peter Maydell 2019-01-13 19:48:18 -05:00 committed by Lioncash
parent 254f882efc
commit 55bc017af4
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
1 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
qemu/target/arm/translate.c
View file

@ -9921,6 +9921,8 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
rd = (insn >> 12) & 0xf; rd = (insn >> 12) & 0xf;
if (insn & (1 << 23)) { if (insn & (1 << 23)) {
/* load/store exclusive */ /* load/store exclusive */
bool is_ld = extract32(insn, 20, 1);
bool is_lasr = !extract32(insn, 8, 1);
int op2 = (insn >> 8) & 3; int op2 = (insn >> 8) & 3;
op1 = (insn >> 21) & 0x3; op1 = (insn >> 21) & 0x3;
@ -9948,11 +9950,12 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
addr = tcg_temp_local_new_i32(tcg_ctx); addr = tcg_temp_local_new_i32(tcg_ctx);
load_reg_var(s, addr, rn); load_reg_var(s, addr, rn);
/* Since the emulation does not have barriers, if (is_lasr && !is_ld) {
the acquire/release semantics need no special tcg_gen_mb(tcg_ctx, TCG_MO_ALL | TCG_BAR_STRL);
handling */ }
if (op2 == 0) { if (op2 == 0) {
if (insn & (1 << 20)) { if (is_ld) {
tmp = tcg_temp_new_i32(tcg_ctx); tmp = tcg_temp_new_i32(tcg_ctx);
switch (op1) { switch (op1) {
case 0: /* lda */ case 0: /* lda */
@ -9998,7 +10001,7 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
} }
tcg_temp_free_i32(tcg_ctx, tmp); tcg_temp_free_i32(tcg_ctx, tmp);
} }
} else if (insn & (1 << 20)) { } else if (is_ld) {
switch (op1) { switch (op1) {
case 0: /* ldrex */ case 0: /* ldrex */
gen_load_exclusive(s, rd, 15, addr, 2); gen_load_exclusive(s, rd, 15, addr, 2);
@ -10035,6 +10038,10 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
} }
} }
tcg_temp_free_i32(tcg_ctx, addr); tcg_temp_free_i32(tcg_ctx, addr);
if (is_lasr && is_ld) {
tcg_gen_mb(tcg_ctx, TCG_MO_ALL | TCG_BAR_LDAQ);
}
} else if ((insn & 0x00300f00) == 0) { } else if ((insn & 0x00300f00) == 0) {
/* 0bcccc_0001_0x00_xxxx_xxxx_0000_1001_xxxx /* 0bcccc_0001_0x00_xxxx_xxxx_0000_1001_xxxx
* - SWP, SWPB * - SWP, SWPB
@ -11046,6 +11053,8 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
tcg_gen_addi_i32(tcg_ctx, tmp, tmp, s->pc); tcg_gen_addi_i32(tcg_ctx, tmp, tmp, s->pc);
store_reg(s, 15, tmp); store_reg(s, 15, tmp);
} else { } else {
bool is_lasr = false;
bool is_ld = extract32(insn, 20, 1);
int op2 = (insn >> 6) & 0x3; int op2 = (insn >> 6) & 0x3;
op = (insn >> 4) & 0x3; op = (insn >> 4) & 0x3;
switch (op2) { switch (op2) {
@ -11067,12 +11076,18 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
case 3: case 3:
/* Load-acquire/store-release exclusive */ /* Load-acquire/store-release exclusive */
ARCH(8); ARCH(8);
is_lasr = true;
break; break;
} }
if (is_lasr && !is_ld) {
tcg_gen_mb(tcg_ctx, TCG_MO_ALL | TCG_BAR_STRL);
}
addr = tcg_temp_local_new_i32(tcg_ctx); addr = tcg_temp_local_new_i32(tcg_ctx);
load_reg_var(s, addr, rn); load_reg_var(s, addr, rn);
if (!(op2 & 1)) { if (!(op2 & 1)) {
if (insn & (1 << 20)) { if (is_ld) {
tmp = tcg_temp_new_i32(tcg_ctx); tmp = tcg_temp_new_i32(tcg_ctx);
switch (op) { switch (op) {
case 0: /* ldab */ case 0: /* ldab */
@ -11111,12 +11126,16 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
} }
tcg_temp_free_i32(tcg_ctx, tmp); tcg_temp_free_i32(tcg_ctx, tmp);
} }
} else if (insn & (1 << 20)) { } else if (is_ld) {
gen_load_exclusive(s, rs, rd, addr, op); gen_load_exclusive(s, rs, rd, addr, op);
} else { } else {
gen_store_exclusive(s, rm, rs, rd, addr, op); gen_store_exclusive(s, rm, rs, rd, addr, op);
} }
tcg_temp_free_i32(tcg_ctx, addr); tcg_temp_free_i32(tcg_ctx, addr);
if (is_lasr && is_ld) {
tcg_gen_mb(tcg_ctx, TCG_MO_ALL | TCG_BAR_LDAQ);
}
} }
} else { } else {
/* Load/store multiple, RFE, SRS. */ /* Load/store multiple, RFE, SRS. */