yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-07-09 17:47:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

tcg: Initialize return value after exit_atomic

Browse source 
Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize
the output. Even though this code is dead, it gets translated, and
without the initialization we encounter a tcg_error.

Backports commit 79b1af906245558c30e0a5faf26cb52b63f83cce from qemu
This commit is contained in:
Richard Henderson 2018-03-02 15:10:25 -05:00 committed by Lioncash
parent 108354cc4a
commit 69116abafc
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
qemu/tcg/tcg-op.c
View file

@ -2924,6 +2924,9 @@ void tcg_gen_atomic_cmpxchg_i64(TCGContext *s,
#endif #endif
#else #else
gen_helper_exit_atomic(s, s->tcg_env); gen_helper_exit_atomic(s, s->tcg_env);
/* Produce a result, so that we have a well-formed opcode stream
with respect to uses of the result in the (dead) code following. */
tcg_gen_movi_i64(s, retv, 0);
#endif /* CONFIG_ATOMIC64 */ #endif /* CONFIG_ATOMIC64 */
} else { } else {
TCGv_i32 c32 = tcg_temp_new_i32(s); TCGv_i32 c32 = tcg_temp_new_i32(s);
@ -3033,6 +3036,9 @@ static void do_atomic_op_i64(TCGContext *s,
#endif #endif
#else #else
gen_helper_exit_atomic(s, s->tcg_env); gen_helper_exit_atomic(s, s->tcg_env);
/* Produce a result, so that we have a well-formed opcode stream
with respect to uses of the result in the (dead) code following. */
tcg_gen_movi_i64(s, ret, 0);
#endif /* CONFIG_ATOMIC64 */ #endif /* CONFIG_ATOMIC64 */
} else { } else {
TCGv_i32 v32 = tcg_temp_new_i32(s); TCGv_i32 v32 = tcg_temp_new_i32(s);