mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2025-03-29 02:16:59 +00:00
target-i386: Dump unknown opcodes with -d unimp
We discriminate here between opcodes that are illegal in the current cpu mode or with illegal arguments (such as modrm.mod == 3) and encodings that are unknown (such as an unimplemented isa extension). Backports commit b9f9c5b41aab06479cb1695990b7cca98ef84fc7 from qemu
This commit is contained in:
Richard Henderson
Lioncash
parent
1c096b8fa2
commit
7775b05fb8
|
|
@ -74,6 +74,7 @@ typedef struct DisasContext {
|
|||
int prefix;
|
||||
TCGMemOp aflag;
|
||||
TCGMemOp dflag;
|
||||
target_ulong pc_start;
|
||||
target_ulong pc; /* pc = eip + cs_base */
|
||||
int is_jmp; /* 1 = means jump (stop translation), 2 means CPU
|
||||
static state change (stop translation) */
|
||||
|
|
@ -2695,6 +2696,30 @@ static void gen_exception(DisasContext *s, int trapno, target_ulong cur_eip)
|
|||
s->is_jmp = DISAS_TB_JUMP;
|
||||
}
|
||||
|
||||
/* Generate #UD for the current instruction. The assumption here is that
|
||||
the instruction is known, but it isn't allowed in the current cpu mode. */
|
||||
static void gen_illegal_opcode(DisasContext *s)
|
||||
{
|
||||
gen_exception(s, EXCP06_ILLOP, s->pc_start - s->cs_base);
|
||||
}
|
||||
|
||||
/* Similarly, except that the assumption here is that we don't decode
|
||||
the instruction at all -- either a missing opcode, an unimplemented
|
||||
feature, or just a bogus instruction stream. */
|
||||
static void gen_unknown_opcode(CPUX86State *env, DisasContext *s)
|
||||
{
|
||||
gen_illegal_opcode(s);
|
||||
|
||||
if (qemu_loglevel_mask(LOG_UNIMP)) {
|
||||
target_ulong pc = s->pc_start, end = s->pc;
|
||||
qemu_log("ILLOPC: " TARGET_FMT_lx ":", pc);
|
||||
for (; pc < end; ++pc) {
|
||||
qemu_log(" %02x", cpu_ldub_code(env, pc));
|
||||
}
|
||||
qemu_log("\n");
|
||||
}
|
||||
}
|
||||
|
||||
/* an interrupt is different from an exception because of the
|
||||
privilege checks */
|
||||
static void gen_interrupt(DisasContext *s, int intno,
|
||||
|
|
@ -3459,7 +3484,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
b1 = 0;
|
||||
sse_fn_epp = sse_op_table1[b][b1];
|
||||
if (!sse_fn_epp) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
if ((b <= 0x5f && b >= 0x10) || b == 0xc6 || b == 0xc2) {
|
||||
is_xmm = 1;
|
||||
|
|
@ -3478,15 +3503,19 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
}
|
||||
if (s->flags & HF_EM_MASK) {
|
||||
illegal_op:
|
||||
gen_exception(s, EXCP06_ILLOP, pc_start - s->cs_base);
|
||||
gen_illegal_opcode(s);
|
||||
return;
|
||||
}
|
||||
if (is_xmm && !(s->flags & HF_OSFXSR_MASK))
|
||||
if ((b != 0x38 && b != 0x3a) || (s->prefix & PREFIX_DATA))
|
||||
goto illegal_op;
|
||||
if (is_xmm
|
||||
&& !(s->flags & HF_OSFXSR_MASK)
|
||||
&& ((b != 0x38 && b != 0x3a) || (s->prefix & PREFIX_DATA))) {
|
||||
goto unknown_op;
|
||||
}
|
||||
if (b == 0x0e) {
|
||||
if (!(s->cpuid_ext2_features & CPUID_EXT2_3DNOW))
|
||||
goto illegal_op;
|
||||
if (!(s->cpuid_ext2_features & CPUID_EXT2_3DNOW)) {
|
||||
/* If we were fully decoding this we might use illegal_op. */
|
||||
goto unknown_op;
|
||||
}
|
||||
/* femms */
|
||||
gen_helper_emms(tcg_ctx, cpu_env);
|
||||
return;
|
||||
|
|
@ -3511,8 +3540,9 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
b |= (b1 << 8);
|
||||
switch(b) {
|
||||
case 0x0e7: /* movntq */
|
||||
if (mod == 3)
|
||||
goto illegal_op;
|
||||
if (mod == 3) {
|
||||
goto unknown_op;
|
||||
}
|
||||
gen_lea_modrm(env, s, modrm);
|
||||
gen_stq_env_A0(s, offsetof(CPUX86State, fpregs[reg].mmx));
|
||||
break;
|
||||
|
|
@ -3838,7 +3868,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
case 0x172:
|
||||
case 0x173:
|
||||
if (b1 >= 2) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
val = cpu_ldub_code(env, s->pc++);
|
||||
if (is_xmm) {
|
||||
|
|
@ -3857,7 +3887,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
sse_fn_epp = sse_op_table2[((b - 1) & 3) * 8 +
|
||||
(((modrm >> 3)) & 7)][b1];
|
||||
if (!sse_fn_epp) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
if (is_xmm) {
|
||||
rm = (modrm & 7) | REX_B(s);
|
||||
|
|
@ -4081,12 +4111,12 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
reg = ((modrm >> 3) & 7) | rex_r;
|
||||
mod = (modrm >> 6) & 3;
|
||||
if (b1 >= 2) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
|
||||
sse_fn_epp = sse_op_table6[b].op[b1];
|
||||
if (!sse_fn_epp) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
if (!(s->cpuid_ext_features & sse_op_table6[b].ext_mask))
|
||||
goto illegal_op;
|
||||
|
|
@ -4136,7 +4166,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
}
|
||||
}
|
||||
if (sse_fn_epp == SSE_SPECIAL) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
|
||||
tcg_gen_addi_ptr(tcg_ctx, cpu_ptr0, cpu_env, op1_offset);
|
||||
|
|
@ -4504,12 +4534,12 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -4521,12 +4551,12 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
reg = ((modrm >> 3) & 7) | rex_r;
|
||||
mod = (modrm >> 6) & 3;
|
||||
if (b1 >= 2) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
|
||||
sse_fn_eppi = sse_op_table7[b].op[b1];
|
||||
if (!sse_fn_eppi) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
if (!(s->cpuid_ext_features & sse_op_table7[b].ext_mask))
|
||||
goto illegal_op;
|
||||
|
|
@ -4728,12 +4758,14 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
unknown_op:
|
||||
gen_unknown_opcode(env, s);
|
||||
return;
|
||||
}
|
||||
} else {
|
||||
/* generic MMX or SSE operation */
|
||||
|
|
@ -4806,11 +4838,12 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
}
|
||||
switch(b) {
|
||||
case 0x0f: /* 3DNow! data insns */
|
||||
if (!(s->cpuid_ext2_features & CPUID_EXT2_3DNOW))
|
||||
goto illegal_op;
|
||||
val = cpu_ldub_code(env, s->pc++);
|
||||
sse_fn_epp = sse_op_table5[val];
|
||||
if (!sse_fn_epp) {
|
||||
goto unknown_op;
|
||||
}
|
||||
if (!(s->cpuid_ext2_features & CPUID_EXT2_3DNOW)) {
|
||||
goto illegal_op;
|
||||
}
|
||||
tcg_gen_addi_ptr(tcg_ctx, cpu_ptr0, cpu_env, op1_offset);
|
||||
|
|
@ -4830,7 +4863,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b,
|
|||
/* compare insns */
|
||||
val = cpu_ldub_code(env, s->pc++);
|
||||
if (val >= 8)
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
sse_fn_epp = sse_op_table4[val][b1];
|
||||
|
||||
tcg_gen_addi_ptr(tcg_ctx, cpu_ptr0, cpu_env, op1_offset);
|
||||
|
|
@ -4917,7 +4950,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
bool cc_op_dirty = s->cc_op_dirty;
|
||||
bool changed_cc_op = false;
|
||||
|
||||
s->pc = pc_start;
|
||||
s->pc_start = s->pc = pc_start;
|
||||
|
||||
// end address tells us to stop emulation
|
||||
if (s->pc == s->uc->addr_end) {
|
||||
|
|
@ -5069,7 +5102,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
b = 0x13a;
|
||||
break;
|
||||
default: /* Reserved for future use. */
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
}
|
||||
s->vex_v = (~vex3 >> 3) & 0xf;
|
||||
|
|
@ -5421,7 +5454,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
}
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -5434,7 +5467,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
rm = (modrm & 7) | REX_B(s);
|
||||
op = (modrm >> 3) & 7;
|
||||
if (op >= 2 && b == 0xfe) {
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
if (CODE64(s)) {
|
||||
if (op == 2 || op == 4) {
|
||||
|
|
@ -5527,7 +5560,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_push_v(s, cpu_T0);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -6472,7 +6505,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_helper_fwait(tcg_ctx, cpu_env);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x0c: /* grp d9/4 */
|
||||
|
|
@ -6491,7 +6524,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_helper_fxam_ST0(tcg_ctx, cpu_env);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x0d: /* grp d9/5 */
|
||||
|
|
@ -6526,7 +6559,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_helper_fldz_ST0(tcg_ctx, cpu_env);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
}
|
||||
break;
|
||||
|
|
@ -6626,7 +6659,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_helper_fpop(tcg_ctx, cpu_env);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x1c:
|
||||
|
|
@ -6644,7 +6677,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
case 4: /* fsetpm (287 only, just do nop here) */
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x1d: /* fucomi */
|
||||
|
|
@ -6696,7 +6729,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_helper_fpop(tcg_ctx, cpu_env);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x38: /* ffreep sti, undocumented op */
|
||||
|
|
@ -6711,7 +6744,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
gen_op_mov_reg_v(tcg_ctx, MO_16, R_EAX, cpu_T0);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
case 0x3d: /* fucomip */
|
||||
|
|
@ -7203,7 +7236,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
val = cpu_ldub_code(env, s->pc++);
|
||||
tcg_gen_movi_tl(tcg_ctx, cpu_T1, val);
|
||||
if (op < 4)
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
op -= 4;
|
||||
goto bt_op;
|
||||
case 0x1a3: /* bt Gv, Ev */
|
||||
|
|
@ -7720,7 +7753,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s,
|
|||
set_cc_op(s, CC_OP_EFLAGS);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -8041,7 +8074,7 @@ case 0x101:
|
|||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -8410,7 +8443,7 @@ case 0x101:
|
|||
}
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
}
|
||||
break;
|
||||
|
|
@ -8646,7 +8679,7 @@ case 0x101:
|
|||
}
|
||||
break;
|
||||
}
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
|
||||
case 0xf8: /* sfence / pcommit */
|
||||
if (prefixes & PREFIX_DATA) {
|
||||
|
|
@ -8688,7 +8721,7 @@ case 0x101:
|
|||
break;
|
||||
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
@ -8757,7 +8790,7 @@ case 0x101:
|
|||
gen_sse(env, s, b, pc_start, rex_r);
|
||||
break;
|
||||
default:
|
||||
goto illegal_op;
|
||||
goto unknown_op;
|
||||
}
|
||||
/* lock generation */
|
||||
if (s->prefix & PREFIX_LOCK)
|
||||
|
|
@ -8790,7 +8823,13 @@ case 0x101:
|
|||
if (s->prefix & PREFIX_LOCK)
|
||||
gen_helper_unlock(tcg_ctx, cpu_env);
|
||||
/* XXX: ensure that no lock was generated */
|
||||
gen_exception(s, EXCP06_ILLOP, pc_start - s->cs_base);
|
||||
gen_illegal_opcode(s);
|
||||
return s->pc;
|
||||
unknown_op:
|
||||
if (s->prefix & PREFIX_LOCK)
|
||||
gen_helper_unlock(tcg_ctx, cpu_env);
|
||||
/* XXX: ensure that no lock was generated */
|
||||
gen_unknown_opcode(env, s);
|
||||
return s->pc;
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue