yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-07-10 11:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

target/arm: Clean up 4-operand predicate expansion

Browse source 
Move the check for !S into do_pppp_flags, which allows to merge in
do_vecop4_p. Split out gen_gvec_fn_ppp without sve_access_check,
to mirror gen_gvec_fn_zzz.

Backport dd81a8d7cf5c90963603806e58a217bbe759f75e
This commit is contained in:
Richard Henderson 2021-02-26 14:07:12 -05:00 committed by Lioncash
parent 7bef6489a8
commit c8c247410f
1 changed files with 76 additions and 134 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

210
qemu/target/arm/translate-sve.c
View file

@ -178,33 +178,14 @@ static void do_dupi_z(DisasContext *s, int rd, uint64_t word)
} }
/* Invoke a vector expander on three Pregs. */ /* Invoke a vector expander on three Pregs. */
static bool do_vector3_p(DisasContext *s, GVecGen3Fn *gvec_fn, static void gen_gvec_fn_ppp(DisasContext *s, GVecGen3Fn *gvec_fn,
int esz, int rd, int rn, int rm) int rd, int rn, int rm)
{ {
if (sve_access_check(s)) { TCGContext *tcg_ctx = s->uc->tcg_ctx;
TCGContext *tcg_ctx = s->uc->tcg_ctx; unsigned psz = pred_gvec_reg_size(s);
unsigned psz = pred_gvec_reg_size(s); gvec_fn(tcg_ctx, MO_64, pred_full_reg_offset(s, rd),
gvec_fn(tcg_ctx, esz, pred_full_reg_offset(s, rd), pred_full_reg_offset(s, rn),
pred_full_reg_offset(s, rn), pred_full_reg_offset(s, rm), psz, psz);
pred_full_reg_offset(s, rm), psz, psz);
}
return true;
}
/* Invoke a vector operation on four Pregs. */
static bool do_vecop4_p(DisasContext *s, const GVecGen4 *gvec_op,
int rd, int rn, int rm, int rg)
{
if (sve_access_check(s)) {
TCGContext *tcg_ctx = s->uc->tcg_ctx;
unsigned psz = pred_gvec_reg_size(s);
tcg_gen_gvec_4(tcg_ctx, pred_full_reg_offset(s, rd),
pred_full_reg_offset(s, rn),
pred_full_reg_offset(s, rm),
pred_full_reg_offset(s, rg),
psz, psz, gvec_op);
}
return true;
} }
/* Invoke a vector move on two Pregs. */ /* Invoke a vector move on two Pregs. */
@ -1129,6 +1110,11 @@ static bool do_pppp_flags(DisasContext *s, arg_rprr_s *a,
int mofs = pred_full_reg_offset(s, a->rm); int mofs = pred_full_reg_offset(s, a->rm);
int gofs = pred_full_reg_offset(s, a->pg); int gofs = pred_full_reg_offset(s, a->pg);
if (!a->s) {
tcg_gen_gvec_4(tcg_ctx, dofs, nofs, mofs, gofs, psz, psz, gvec_op);
return true;
}
if (psz == 8) { if (psz == 8) {
/* Do the operation and the flags generation in temps. */ /* Do the operation and the flags generation in temps. */
TCGv_i64 pd = tcg_temp_new_i64(tcg_ctx); TCGv_i64 pd = tcg_temp_new_i64(tcg_ctx);
@ -1183,28 +1169,29 @@ static void gen_and_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_AND_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_AND_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_and_pg_i64, .fni8 = gen_and_pg_i64,
NULL, .fniv = gen_and_pg_vec,
gen_and_pg_vec, .fno = gen_helper_sve_and_pppp,
gen_helper_sve_and_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) {
return do_pppp_flags(s, a, &op); if (!a->s) {
} else if (a->rn == a->rm) { if (!sve_access_check(s)) {
if (a->pg == a->rn) { return true;
return do_mov_p(s, a->rd, a->rn); }
} else { if (a->rn == a->rm) {
return do_vector3_p(s, tcg_gen_gvec_and, 0, a->rd, a->rn, a->pg); if (a->pg == a->rn) {
do_mov_p(s, a->rd, a->rn);
} else {
gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->pg);
}
return true;
} else if (a->pg == a->rn || a->pg == a->rm) {
gen_gvec_fn_ppp(s, tcg_gen_gvec_and, a->rd, a->rn, a->rm);
return true;
} }
} else if (a->pg == a->rn || a->pg == a->rm) {
return do_vector3_p(s, tcg_gen_gvec_and, 0, a->rd, a->rn, a->rm);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
} }
return do_pppp_flags(s, a, &op);
} }
static void gen_bic_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_bic_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1223,22 +1210,19 @@ static void gen_bic_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_BIC_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_BIC_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_bic_pg_i64, .fni8 = gen_bic_pg_i64,
NULL, .fniv = gen_bic_pg_vec,
gen_bic_pg_vec, .fno = gen_helper_sve_bic_pppp,
gen_helper_sve_bic_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) {
return do_pppp_flags(s, a, &op); if (!a->s && a->pg == a->rn) {
} else if (a->pg == a->rn) { if (sve_access_check(s)) {
return do_vector3_p(s, tcg_gen_gvec_andc, 0, a->rd, a->rn, a->rm); gen_gvec_fn_ppp(s, tcg_gen_gvec_andc, a->rd, a->rn, a->rm);
} else { }
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg); return true;
} }
return do_pppp_flags(s, a, &op);
} }
static void gen_eor_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_eor_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1257,20 +1241,12 @@ static void gen_eor_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_EOR_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_EOR_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_eor_pg_i64, .fni8 = gen_eor_pg_i64,
NULL, .fniv = gen_eor_pg_vec,
gen_eor_pg_vec, .fno = gen_helper_sve_eor_pppp,
gen_helper_sve_eor_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) { return do_pppp_flags(s, a, &op);
return do_pppp_flags(s, a, &op);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
}
} }
static void gen_sel_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_sel_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1291,20 +1267,16 @@ static void gen_sel_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_SEL_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_SEL_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_sel_pg_i64, .fni8 = gen_sel_pg_i64,
NULL, .fniv = gen_sel_pg_vec,
gen_sel_pg_vec, .fno = gen_helper_sve_sel_pppp,
gen_helper_sve_sel_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) { if (a->s) {
return false; return false;
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
} }
return do_pppp_flags(s, a, &op);
} }
static void gen_orr_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_orr_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1323,22 +1295,16 @@ static void gen_orr_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_ORR_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_ORR_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_orr_pg_i64, .fni8 = gen_orr_pg_i64,
NULL, .fniv = gen_orr_pg_vec,
gen_orr_pg_vec, .fno = gen_helper_sve_orr_pppp,
gen_helper_sve_orr_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) {
return do_pppp_flags(s, a, &op); if (!a->s && a->pg == a->rn && a->rn == a->rm) {
} else if (a->pg == a->rn && a->rn == a->rm) {
return do_mov_p(s, a->rd, a->rn); return do_mov_p(s, a->rd, a->rn);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
} }
return do_pppp_flags(s, a, &op);
} }
static void gen_orn_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_orn_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1357,20 +1323,12 @@ static void gen_orn_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_ORN_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_ORN_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_orn_pg_i64, .fni8 = gen_orn_pg_i64,
NULL, .fniv = gen_orn_pg_vec,
gen_orn_pg_vec, .fno = gen_helper_sve_orn_pppp,
gen_helper_sve_orn_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) { return do_pppp_flags(s, a, &op);
return do_pppp_flags(s, a, &op);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
}
} }
static void gen_nor_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_nor_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1389,20 +1347,12 @@ static void gen_nor_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec p
static bool trans_NOR_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_NOR_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_nor_pg_i64, .fni8 = gen_nor_pg_i64,
NULL, .fniv = gen_nor_pg_vec,
gen_nor_pg_vec, .fno = gen_helper_sve_nor_pppp,
gen_helper_sve_nor_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) { return do_pppp_flags(s, a, &op);
return do_pppp_flags(s, a, &op);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
}
} }
static void gen_nand_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg) static void gen_nand_pg_i64(TCGContext *s, TCGv_i64 pd, TCGv_i64 pn, TCGv_i64 pm, TCGv_i64 pg)
@ -1421,20 +1371,12 @@ static void gen_nand_pg_vec(TCGContext *s, unsigned vece, TCGv_vec pd, TCGv_vec
static bool trans_NAND_pppp(DisasContext *s, arg_rprr_s *a) static bool trans_NAND_pppp(DisasContext *s, arg_rprr_s *a)
{ {
static const GVecGen4 op = { static const GVecGen4 op = {
gen_nand_pg_i64, .fni8 = gen_nand_pg_i64,
NULL, .fniv = gen_nand_pg_vec,
gen_nand_pg_vec, .fno = gen_helper_sve_nand_pppp,
gen_helper_sve_nand_pppp, .prefer_i64 = TCG_TARGET_REG_BITS == 64,
0,
0,
0,
TCG_TARGET_REG_BITS == 64,
}; };
if (a->s) { return do_pppp_flags(s, a, &op);
return do_pppp_flags(s, a, &op);
} else {
return do_vecop4_p(s, &op, a->rd, a->rn, a->rm, a->pg);
}
} }
/* /*