yuzu/unicorn
1
0
Fork 0
mirror of https://github.com/yuzu-emu/unicorn.git synced 2025-01-11 05:05:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qapi-visit: Use common idiom in gen_visit_fields_decl()

Browse source 
We have several instances of methods that do an early exit if
output is not needed, then log that output is being generated,
and finally produce the output; see qapi-types.py:gen_object()
and qapi-visit.py:gen_visit_implicit_struct(). The odd man
out was gen_visit_fields_decl(); rearrange it to be more like
the others. No semantic change or difference to generated code.

Backports commit 2208d64998c5f867ccee7eeee298971685bf822d from qemu
This commit is contained in:
Eric Blake 2018-02-20 16:03:43 -05:00 committed by Lioncash
parent b513481b9a
commit dc706426c9
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
qemu/scripts/qapi-visit.py
View file

@ -34,15 +34,14 @@ void visit_type_%(c_name)s(Visitor *v, const char *name, %(c_type)sobj, Error **
def gen_visit_fields_decl(typ):
ret = ''
if typ.name not in struct_fields_seen:
ret += mcgen('''
if typ.name in struct_fields_seen:
return ''
struct_fields_seen.add(typ.name)
return mcgen('''
static void visit_type_%(c_type)s_fields(Visitor *v, %(c_type)s *obj, Error **errp);
''',
c_type=typ.c_name())
struct_fields_seen.add(typ.name)
return ret
c_type=typ.c_name())
def gen_visit_implicit_struct(typ):
if typ in implicit_structs_seen: