qapi: Make all visitors supply uint64 callbacks

Our qapi visitor contract supports multiple integer visitors,
but left the type_uint64 visitor as optional (falling back on
type_int64); which in turn can lead to awkward behavior with
numbers larger than INT64_MAX (the user has to be aware of
twos complement, and deal with negatives).

This patch does not address the disparity in handling large
values as negatives. It merely moves the fallback from uint64
to int64 from the visitor core to the visitors, where the issue
can actually be fixed, by implementing the missing type_uint64()
callbacks on top of the respective type_int64() callbacks, and
with a FIXME comment explaining why that's wrong.

With that done, we now have a type_uint64() callback in every
driver, so we can make it mandatory from the core. And although
the type_int64() callback can cover the entire valid range of
type_uint{8,16,32} on valid user input, using type_uint64() to
avoid mixed signedness makes more sense.

Backports commit f755dea79dc81b0d6a8f6414e0672e165e28d8ba from qemu
This commit is contained in:
Eric Blake 2018-02-19 11:57:56 -05:00 committed by Lioncash
parent 5b5299bdee
commit eeffd97458
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
6 changed files with 64 additions and 28 deletions

View file

@ -38,6 +38,12 @@ struct Visitor
void (*type_int64)(Visitor *v, int64_t *obj, const char *name, void (*type_int64)(Visitor *v, int64_t *obj, const char *name,
Error **errp); Error **errp);
/* Must be set. */ /* Must be set. */
void (*type_uint64)(Visitor *v, uint64_t *obj, const char *name,
Error **errp);
/* Optional; fallback is type_uint64(). */
void (*type_size)(Visitor *v, uint64_t *obj, const char *name,
Error **errp);
/* Must be set. */
void (*type_bool)(Visitor *v, bool *obj, const char *name, Error **errp); void (*type_bool)(Visitor *v, bool *obj, const char *name, Error **errp);
void (*type_str)(Visitor *v, char **obj, const char *name, Error **errp); void (*type_str)(Visitor *v, char **obj, const char *name, Error **errp);
void (*type_number)(Visitor *v, double *obj, const char *name, void (*type_number)(Visitor *v, double *obj, const char *name,
@ -50,12 +56,9 @@ struct Visitor
void (*type_uint8)(Visitor *v, uint8_t *obj, const char *name, Error **errp); void (*type_uint8)(Visitor *v, uint8_t *obj, const char *name, Error **errp);
void (*type_uint16)(Visitor *v, uint16_t *obj, const char *name, Error **errp); void (*type_uint16)(Visitor *v, uint16_t *obj, const char *name, Error **errp);
void (*type_uint32)(Visitor *v, uint32_t *obj, const char *name, Error **errp); void (*type_uint32)(Visitor *v, uint32_t *obj, const char *name, Error **errp);
void (*type_uint64)(Visitor *v, uint64_t *obj, const char *name, Error **errp);
void (*type_int8)(Visitor *v, int8_t *obj, const char *name, Error **errp); void (*type_int8)(Visitor *v, int8_t *obj, const char *name, Error **errp);
void (*type_int16)(Visitor *v, int16_t *obj, const char *name, Error **errp); void (*type_int16)(Visitor *v, int16_t *obj, const char *name, Error **errp);
void (*type_int32)(Visitor *v, int32_t *obj, const char *name, Error **errp); void (*type_int32)(Visitor *v, int32_t *obj, const char *name, Error **errp);
/* visit_type_size() falls back to (*type_uint64)() if type_size is unset */
void (*type_size)(Visitor *v, uint64_t *obj, const char *name, Error **errp);
bool (*start_union)(Visitor *v, bool data_present, Error **errp); bool (*start_union)(Visitor *v, bool data_present, Error **errp);
void (*end_union)(Visitor *v, bool data_present, Error **errp); void (*end_union)(Visitor *v, bool data_present, Error **errp);
}; };

View file

@ -142,6 +142,11 @@ static void qapi_dealloc_type_int64(Visitor *v, int64_t *obj, const char *name,
{ {
} }
static void qapi_dealloc_type_uint64(Visitor *v, uint64_t *obj,
const char *name, Error **errp)
{
}
static void qapi_dealloc_type_bool(Visitor *v, bool *obj, const char *name, static void qapi_dealloc_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp) Error **errp)
{ {
@ -213,6 +218,7 @@ QapiDeallocVisitor *qapi_dealloc_visitor_new(void)
v->visitor.end_list = qapi_dealloc_end_list; v->visitor.end_list = qapi_dealloc_end_list;
v->visitor.type_enum = qapi_dealloc_type_enum; v->visitor.type_enum = qapi_dealloc_type_enum;
v->visitor.type_int64 = qapi_dealloc_type_int64; v->visitor.type_int64 = qapi_dealloc_type_int64;
v->visitor.type_uint64 = qapi_dealloc_type_uint64;
v->visitor.type_bool = qapi_dealloc_type_bool; v->visitor.type_bool = qapi_dealloc_type_bool;
v->visitor.type_str = qapi_dealloc_type_str; v->visitor.type_str = qapi_dealloc_type_str;
v->visitor.type_number = qapi_dealloc_type_number; v->visitor.type_number = qapi_dealloc_type_number;

View file

@ -103,14 +103,14 @@ void visit_type_int(Visitor *v, int64_t *obj, const char *name, Error **errp)
void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Error **errp) void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Error **errp)
{ {
int64_t value; uint64_t value;
if (v->type_uint8) { if (v->type_uint8) {
v->type_uint8(v, obj, name, errp); v->type_uint8(v, obj, name, errp);
} else { } else {
value = *obj; value = *obj;
v->type_int64(v, &value, name, errp); v->type_uint64(v, &value, name, errp);
if (value < 0 || value > UINT8_MAX) { if (value > UINT8_MAX) {
/* FIXME questionable reuse of errp if callback changed /* FIXME questionable reuse of errp if callback changed
value on error */ value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
@ -123,14 +123,14 @@ void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Error **errp)
void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, Error **errp) void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, Error **errp)
{ {
int64_t value; uint64_t value;
if (v->type_uint16) { if (v->type_uint16) {
v->type_uint16(v, obj, name, errp); v->type_uint16(v, obj, name, errp);
} else { } else {
value = *obj; value = *obj;
v->type_int64(v, &value, name, errp); v->type_uint64(v, &value, name, errp);
if (value < 0 || value > UINT16_MAX) { if (value > UINT16_MAX) {
/* FIXME questionable reuse of errp if callback changed /* FIXME questionable reuse of errp if callback changed
value on error */ value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
@ -143,14 +143,14 @@ void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, Error **errp
void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, Error **errp) void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, Error **errp)
{ {
int64_t value; uint64_t value;
if (v->type_uint32) { if (v->type_uint32) {
v->type_uint32(v, obj, name, errp); v->type_uint32(v, obj, name, errp);
} else { } else {
value = *obj; value = *obj;
v->type_int64(v, &value, name, errp); v->type_uint64(v, &value, name, errp);
if (value < 0 || value > UINT32_MAX) { if (value > UINT32_MAX) {
/* FIXME questionable reuse of errp if callback changed /* FIXME questionable reuse of errp if callback changed
value on error */ value on error */
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
@ -163,15 +163,7 @@ void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, Error **errp
void visit_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp) void visit_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
{ {
int64_t value; v->type_uint64(v, obj, name, errp);
if (v->type_uint64) {
v->type_uint64(v, obj, name, errp);
} else {
value = *obj;
v->type_int64(v, &value, name, errp);
*obj = value;
}
} }
void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Error **errp) void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Error **errp)
@ -241,16 +233,10 @@ void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Error **errp)
void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp) void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp)
{ {
int64_t value;
if (v->type_size) { if (v->type_size) {
v->type_size(v, obj, name, errp); v->type_size(v, obj, name, errp);
} else if (v->type_uint64) {
v->type_uint64(v, obj, name, errp);
} else { } else {
value = *obj; v->type_uint64(v, obj, name, errp);
v->type_int64(v, &value, name, errp);
*obj = value;
} }
} }

View file

@ -237,6 +237,22 @@ static void qmp_input_type_int64(Visitor *v, int64_t *obj, const char *name,
*obj = qint_get_int(qint); *obj = qint_get_int(qint);
} }
static void qmp_input_type_uint64(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
{
/* FIXME: qobject_to_qint mishandles values over INT64_MAX */
QmpInputVisitor *qiv = to_qiv(v);
QInt *qint = qobject_to_qint(qmp_input_get_object(qiv, name, true));
if (!qint) {
error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
"integer");
return;
}
*obj = qint_get_int(qint);
}
static void qmp_input_type_bool(Visitor *v, bool *obj, const char *name, static void qmp_input_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp) Error **errp)
{ {
@ -331,6 +347,7 @@ QmpInputVisitor *qmp_input_visitor_new(QObject *obj)
v->visitor.end_list = qmp_input_end_list; v->visitor.end_list = qmp_input_end_list;
v->visitor.type_enum = input_type_enum; v->visitor.type_enum = input_type_enum;
v->visitor.type_int64 = qmp_input_type_int64; v->visitor.type_int64 = qmp_input_type_int64;
v->visitor.type_uint64 = qmp_input_type_uint64;
v->visitor.type_bool = qmp_input_type_bool; v->visitor.type_bool = qmp_input_type_bool;
v->visitor.type_str = qmp_input_type_str; v->visitor.type_str = qmp_input_type_str;
v->visitor.type_number = qmp_input_type_number; v->visitor.type_number = qmp_input_type_number;

View file

@ -163,6 +163,14 @@ static void qmp_output_type_int64(Visitor *v, int64_t *obj, const char *name,
qmp_output_add(qov, name, qint_from_int(*obj)); qmp_output_add(qov, name, qint_from_int(*obj));
} }
static void qmp_output_type_uint64(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
{
/* FIXME: QMP outputs values larger than INT64_MAX as negative */
QmpOutputVisitor *qov = to_qov(v);
qmp_output_add(qov, name, qint_from_int(*obj));
}
static void qmp_output_type_bool(Visitor *v, bool *obj, const char *name, static void qmp_output_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp) Error **errp)
{ {
@ -232,6 +240,7 @@ QmpOutputVisitor *qmp_output_visitor_new(void)
v->visitor.end_list = qmp_output_end_list; v->visitor.end_list = qmp_output_end_list;
v->visitor.type_enum = output_type_enum; v->visitor.type_enum = output_type_enum;
v->visitor.type_int64 = qmp_output_type_int64; v->visitor.type_int64 = qmp_output_type_int64;
v->visitor.type_uint64 = qmp_output_type_uint64;
v->visitor.type_bool = qmp_output_type_bool; v->visitor.type_bool = qmp_output_type_bool;
v->visitor.type_str = qmp_output_type_str; v->visitor.type_str = qmp_output_type_str;
v->visitor.type_number = qmp_output_type_number; v->visitor.type_number = qmp_output_type_number;

View file

@ -227,6 +227,20 @@ error:
"an int64 value or range"); "an int64 value or range");
} }
static void parse_type_uint64(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
{
/* FIXME: parse_type_int64 mishandles values over INT64_MAX */
int64_t i;
Error *err = NULL;
parse_type_int64(v, &i, name, &err);
if (err) {
error_propagate(errp, err);
} else {
*obj = i;
}
}
static void parse_type_bool(Visitor *v, bool *obj, const char *name, static void parse_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp) Error **errp)
{ {
@ -316,6 +330,7 @@ StringInputVisitor *string_input_visitor_new(const char *str)
v->visitor.type_enum = input_type_enum; v->visitor.type_enum = input_type_enum;
v->visitor.type_int64 = parse_type_int64; v->visitor.type_int64 = parse_type_int64;
v->visitor.type_uint64 = parse_type_uint64;
v->visitor.type_size = NULL; v->visitor.type_size = NULL;
v->visitor.type_bool = parse_type_bool; v->visitor.type_bool = parse_type_bool;
v->visitor.type_str = parse_type_str; v->visitor.type_str = parse_type_str;