mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2025-02-02 05:20:59 +00:00
RISC-V: Only Check PMP if MMU translation succeeds
The current implementation unnecessarily checks for PMP even if MMU translation failed. This may trigger a wrong PMP access exception instead of a page exception. For example, the very first instruction fetched after the first satp write in S-Mode will trigger a PMP access fault instead of an instruction fetch page fault. This patch prioritises MMU exceptions over PMP exceptions and only checks for PMP if MMU translation succeeds. This patch is required for future commits that properly report PMP exception violations if PTW succeeds. Backports commit e0f8fa72deba7ac7a7ae06ba25e6498aaad93ace from qemu
This commit is contained in:
parent
6ab36ed89e
commit
f597727171
|
@ -418,6 +418,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
|
|||
" prot %d\n", __func__, address, ret, pa, prot);
|
||||
|
||||
if (riscv_feature(env, RISCV_FEATURE_PMP) &&
|
||||
(ret == TRANSLATE_SUCCESS) &&
|
||||
!pmp_hart_has_privs(env, pa, TARGET_PAGE_SIZE, 1 << access_type)) {
|
||||
ret = TRANSLATE_FAIL;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue