Eric Blake 00e596aad2 qapi: Tighten the regex on valid names ... We already documented that qapi names should match specific patterns (such as starting with a letter unless it was an enum value or a downstream extension). Tighten that from a suggestion into a hard requirement, which frees up names beginning with a single underscore for qapi internal usage. The tighter regex doesn't forbid everything insane that a user could provide (for example, a user could name a type 'Foo-lookup' to collide with the generated 'Foo_lookup[]' for an enum 'Foo'), but does a good job at protecting the most obvious uses, and also happens to reserve single leading underscore for later use. The handling of enum values starting with a digit is tricky: commit 9fb081e introduced a subtle bug by using c_name() on a munged value, which would allow an enum to include the member 'q-int' in spite of our reservation. Furthermore, munging with a leading '_' would fail our tighter regex. So fix it by only munging for leading digits (which are never ticklish in c_name()) and by using a different prefix (I picked 'D', although any letter should do). Add new tests, reserved-member-underscore and reserved-enum-q, to demonstrate the tighter checking. Backports commit 59a92feedc6927e0e1ff87fdaccfb4dd42ad4c84 from qemu		2018-02-19 20:33:18 -05:00
..
create_config	more cleanup qemu/configure	2017-01-19 14:11:54 +08:00
make_device_config.sh	fix file perms	2015-08-28 21:05:38 -07:00
ordereddict.py	import	2015-08-21 15:04:50 +08:00
qapi-event.py	qapi: Share gen_visit_fields()	2018-02-19 18:41:41 -05:00
qapi-types.py	qapi-types: Simplify gen_struct_field[s]	2018-02-19 20:06:38 -05:00
qapi-visit.py	qapi: Track simple union tag in object.local_members	2018-02-19 20:02:03 -05:00
qapi.py	qapi: Tighten the regex on valid names	2018-02-19 20:33:18 -05:00