Eric Blake 0ec9a5adaf qapi: Guarantee NULL obj on input visitor callback error ... Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj'. These are start_struct(), start_alternate(), type_str(), and type_any(). next_list() is similar, but can't fail (see commit 08f9541). While all of them set '*obj' to allocated storage on success, it was not obvious whether '*obj' was guaranteed safe on failure, or whether it was left uninitialized. But a future patch wants to guarantee that visit_type_FOO() does not leak a partially-constructed obj back to the caller; it is easier to implement this if we can reliably state that input visitors assign '*obj' regardless of success or failure, and that on failure *obj is NULL. Add assertions to enforce consistency in the final setting of err vs. *obj. The opts-visitor start_struct() doesn't set an error, but it also was doing a weird check for 0 size; all callers pass in non-zero size if obj is non-NULL. The testsuite has at least one spot where we no longer need to pre-initialize a variable prior to a visit; valgrind confirms that the test is still fine with the cleanup. A later patch will document the design constraint implemented here. Backports commit e58d695e6c3a5cfa0aa2fc91b87ade017ef28b05 from qemu		2018-02-23 14:53:23 -05:00
..
common.json	qapi: Add alias for ErrorClass	2018-02-19 20:38:51 -05:00
Makefile.objs	remove glib dependency by provide compatible replacements	2016-12-18 14:56:58 -08:00
qapi-dealloc-visitor.c	qapi: Adjust layout of FooList types	2018-02-23 14:49:06 -05:00
qapi-visit-core.c	qapi: Guarantee NULL obj on input visitor callback error	2018-02-23 14:53:23 -05:00
qmp-input-visitor.c	qapi: Guarantee NULL obj on input visitor callback error	2018-02-23 14:53:23 -05:00
qmp-output-visitor.c	qapi: Adjust layout of FooList types	2018-02-23 14:49:06 -05:00
string-input-visitor.c	qapi: Guarantee NULL obj on input visitor callback error	2018-02-23 14:53:23 -05:00