Laszlo Ersek 40c04c73b0 target/i386: floatx80: avoid compound literals in static initializers ... Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an object that has static storage duration shall be constant expressions or string literals". The compound literal produced by the make_floatx80() macro is not such a constant expression, per 6.6p7-9. (An implementation may accept it, according to 6.6p10, but is not required to.) Therefore using "floatx80_zero" and make_floatx80() for initializing "f2xm1_table" and "fpatan_table" is not portable. And gcc-4.8 in RHEL-7.6 actually chokes on them: > target/i386/fpu_helper.c:871:5: error: initializer element is not constant > { make_floatx80(0xbfff, 0x8000000000000000ULL), > ^ We've had the make_floatx80_init() macro for this purpose since commit 3bf7e40ab914 ("softfloat: fix for C99", 2012-03-17), so let's use that macro again. Fixes: eca30647fc0 ("target/i386: reimplement f2xm1 using floatx80 operations") Fixes: ff57bb7b632 ("target/i386: reimplement fpatan using floatx80 operations") Backports commit 163b3d1af2552845a60967979aca8d78a6b1b088 from qemu		2021-02-25 23:38:54 -05:00
..
softfloat-helpers.h	softfloat: Name rounding mode enum	2020-05-21 18:02:05 -04:00
softfloat-macros.h	softfloat: Replace flag with bool	2020-05-21 17:48:12 -04:00
softfloat-types.h	softfloat: Name rounding mode enum	2020-05-21 18:02:05 -04:00
softfloat.h	target/i386: floatx80: avoid compound literals in static initializers	2021-02-25 23:38:54 -05:00