mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-12-24 19:15:39 +00:00
7e83274012
The generated code can call visit_end_union() without having called
visit_start_union(). Example:
if (!*obj) {
goto out_obj;
}
visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
if (err) {
goto out_obj; // if we go from here...
}
if (!visit_start_union(v, !!(*obj)->u.data, &err) || err) {
goto out_obj;
}
switch ((*obj)->arch) {
[...]
}
out_obj:
// ... then *obj is true, and ...
error_propagate(errp, err);
err = NULL;
if (*obj) {
// we end up here
visit_end_union(v, !!(*obj)->u.data, &err);
}
error_propagate(errp, err);
Harmless only because no visitor implements end_union(). Clean it up
anyway, by deleting the function as useless.
Messed up since we have visit_end_union (commit cee2ded).
Backports commit 7c91aabd8964cfdf637f302c579c95401f21ce92 from qemu
|
||
|---|---|---|
| .. | ||
| common.json | ||
| Makefile.objs | ||
| qapi-dealloc-visitor.c | ||
| qapi-visit-core.c | ||
| qmp-input-visitor.c | ||
| qmp-output-visitor.c | ||
| string-input-visitor.c | ||