Eric Blake b978871f20 qapi: Don't cast Enum* to int* ... C compilers are allowed to represent enums as a smaller type than int, if all enum values fit in the smaller type. There are even compiler flags that force the use of this smaller representation, although using them changes the ABI of a binary. Therefore, our generated code for visit_type_ENUM() (for all qapi enums) was wrong for casting Enum* to int* when calling visit_type_enum(). It appears that no one has been using compiler ABI switches for qemu, because if they had, we are potentially dereferencing beyond bounds or even risking a SIGBUS on platforms where unaligned pointer dereferencing is fatal. But it is still better to avoid the practice entirely, and just use the correct types. This matches the fix for alternate qapi types, done earlier in commit 0426d53 "qapi: Simplify visiting of alternate types", with generated code changing as: | void visit_type_QType(Visitor *v, QType *obj, const char *name, Error **errp) | { |- visit_type_enum(v, (int *)obj, QType_lookup, "QType", name, errp); |+ int value = *obj; |+ visit_type_enum(v, &value, QType_lookup, "QType", name, errp); |+ *obj = value; | } Backports commit 395a233f7c089f23e3c0d43ce34c709dc5acd7de from qemu		2018-02-19 22:24:19 -05:00
..
create_config	more cleanup qemu/configure	2017-01-19 14:11:54 +08:00
make_device_config.sh	fix file perms	2015-08-28 21:05:38 -07:00
ordereddict.py	import	2015-08-21 15:04:50 +08:00
qapi-event.py	qapi: Improve generated event use of qapi visitor	2018-02-19 22:18:31 -05:00
qapi-types.py	qapi-types: Drop unnedeed ._fwdefn	2018-02-19 21:53:45 -05:00
qapi-visit.py	qapi: Don't cast Enum* to int*	2018-02-19 22:24:19 -05:00
qapi.py	qapi: Improve generated event use of qapi visitor	2018-02-19 22:18:31 -05:00