Peter Maydell 61c0f40ac3 target/arm: Hyp mode R14 is shared with User and System ... Hyp mode is an exception to the general rule that each AArch32 mode has its own r13, r14 and SPSR -- it has a banked r13 and SPSR but shares its r14 with User and System mode. We were incorrectly implementing it as banked, which meant that on entry to Hyp mode r14 was 0 rather than the USR/SYS r14. We provide a new function r14_bank_number() which is like the existing bank_number() but provides the index into env->banked_r14[]; bank_number() provides the index to use for env->banked_r13[] and env->banked_cpsr[]. All the points in the code that were using bank_number() to index into env->banked_r14[] are updated for consintency: * switch_mode() -- this is the only place where we fix an actual bug * aarch64_sync_32_to_64() and aarch64_sync_64_to_32(): no behavioural change as we already special-cased Hyp R14 * kvm32.c: no behavioural change since the guest can't ever be in Hyp mode, but conceptually the right thing to do * msr_banked()/mrs_banked(): we can never get to the case that accesses banked_r14[] with tgtmode == ARM_CPU_MODE_HYP, so no behavioural change Backports commit 593cfa2b637b92d37eef949653840dc065cdb960 from qemu		2018-11-16 21:58:29 -05:00
..
arm	target/arm: Hyp mode R14 is shared with User and System	2018-11-16 21:58:29 -05:00
i386	target/i386: Clear RF on SYSCALL instruction	2018-11-11 08:41:09 -05:00
m68k	m68k: Silence compiler warnings	2018-11-16 21:23:55 -05:00
mips	target/mips: Amend MXU ASE overview note	2018-11-11 07:30:31 -05:00
sparc	Sparc increase ttl number	2018-10-06 04:55:52 -04:00