mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2025-05-29 18:27:16 +00:00
The macro DO_UPCAST() is incorrectly named: it converts from a parent class to a derived class (which is a downcast). Better, and more consistent with some of the other qapi visitors, is to use the container_of() macro through a to_FOO() helper. Names like 'to_ov()' may be a bit short, but for a static helper it doesn't hurt too much, and matches existing practice in files like qmp-input-visitor.c. Our current definition of container_of() is weaker than DO_UPCAST(), in that it does not require the derived class to have Visitor as its first member, but this does not hurt our usage patterns in qapi visitors. Backports commit d7bea75d35a44023efc9d481d3a1a2600677b2ef from qemu |
||
---|---|---|
.. | ||
common.json | ||
Makefile.objs | ||
qapi-dealloc-visitor.c | ||
qapi-visit-core.c | ||
qmp-input-visitor.c | ||
qmp-output-visitor.c | ||
string-input-visitor.c |