mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-12-24 19:15:39 +00:00
49b8891872
The previous commit documented an inconsistency in how we are using the stack of qmp-output-visitor. Normally, pushing a single top-level object puts the object on the stack twice: once as the root, and once as the current container being appended to; but popping that struct only pops once. However, qmp_ouput_add() was trying to either set up the added object as the new root (works if you parse two top-level scalars in a row: the second replaces the first as the root) or as a member of the current container (works as long as you have an open container on the stack; but if you have popped the first top-level container, it then resolves to the root and still tries to add into that existing container). Fix the stupidity by not tracking two separate things in the stack. Drop the now-useless qmp_output_first() and qmp_output_last() while at it. Saved for a later patch: we still are rather sloppy in that qmp_output_get_object() can be called in the middle of a parse, rather than requiring that a visit is complete. Backports commit 455ba08afde784466420449d01c6458f88349d55 from qemu |
||
|---|---|---|
| .. | ||
| common.json | ||
| Makefile.objs | ||
| qapi-dealloc-visitor.c | ||
| qapi-visit-core.c | ||
| qmp-input-visitor.c | ||
| qmp-output-visitor.c | ||
| string-input-visitor.c | ||