unicorn/qemu/include/qapi
Eric Blake 7e83274012
qapi-visit: Kill unused visit_end_union()
The generated code can call visit_end_union() without having called
visit_start_union(). Example:

if (!*obj) {
goto out_obj;
}
visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
if (err) {
goto out_obj; // if we go from here...
}
if (!visit_start_union(v, !!(*obj)->u.data, &err) || err) {
goto out_obj;
}
switch ((*obj)->arch) {
[...]
}
out_obj:
// ... then *obj is true, and ...
error_propagate(errp, err);
err = NULL;
if (*obj) {
// we end up here
visit_end_union(v, !!(*obj)->u.data, &err);
}
error_propagate(errp, err);

Harmless only because no visitor implements end_union(). Clean it up
anyway, by deleting the function as useless.

Messed up since we have visit_end_union (commit cee2ded).

Backports commit 7c91aabd8964cfdf637f302c579c95401f21ce92 from qemu
2018-02-19 22:22:24 -05:00
..
qmp qapi: Convert QType into QAPI built-in enum type 2018-02-19 21:47:05 -05:00
dealloc-visitor.h import 2015-08-21 15:04:50 +08:00
error.h qapi: Change munging of CamelCase enum values 2018-02-19 20:40:15 -05:00
qmp-input-visitor.h import 2015-08-21 15:04:50 +08:00
qmp-output-visitor.h import 2015-08-21 15:04:50 +08:00
string-input-visitor.h import 2015-08-21 15:04:50 +08:00
visitor-impl.h qapi-visit: Kill unused visit_end_union() 2018-02-19 22:22:24 -05:00
visitor.h qapi-visit: Kill unused visit_end_union() 2018-02-19 22:22:24 -05:00