unicorn/qemu
Eduardo Habkost e71c7b7819
i386: Don't override -cpu options on -cpu host/max
The existing code for "host" and "max" CPU models overrides every
single feature in the CPU object at realize time, even the ones
that were explicitly enabled or disabled by the user using
"feat=on" or "feat=off", while features set using +feat/-feat are
kept.

This means "-cpu host,+invtsc" works as expected, while
"-cpu host,invtsc=on" doesn't.

This was a known bug, already documented in a comment inside
x86_cpu_expand_features(). What makes this bug worse now is that
libvirt 3.0.0 and newer now use "feat=on|off" instead of
+feat/-feat when it detects a QEMU version that supports it (see
libvirt commit d47db7b16dd5422c7e487c8c8ee5b181a2f9cd66).

Change the feature property getter/setter to set a
env->user_features field, to keep track of features that were
explicitly changed using QOM properties. Then make the
max_features code not override user features when handling "-cpu
host" and "-cpu max".

This will also allow us to remove the plus_features/minus_features
hack in the future, but I plan to do that after 2.9.0 is
released.

Backports commit d4a606b38b5d4b3689b86cc1575908e82179ecfb from qemu
2018-03-02 14:22:45 -05:00
..
crypto crypto: Clean up includes 2018-02-19 00:47:40 -05:00
default-configs arm64eb: add support for ARM64 big endian. 2017-04-24 23:30:01 +08:00
docs docs: clarify memory region lifecycle 2018-02-12 15:11:21 -05:00
fpu softfloat: Use correct type in float64_to_uint64_round_to_zero() 2018-03-02 10:44:10 -05:00
hw i386: Remove AMD feature flag aliases from Opteron models 2018-03-01 23:49:04 -05:00
include armv7m: Fix reads of CONTROL register bit 1 2018-03-02 13:26:38 -05:00
qapi qapi: Fix object input visit beyond end of list 2018-03-02 12:22:50 -05:00
qobject util/cutils: Rename qemu_strtoll(), qemu_strtoull() 2018-03-02 08:39:45 -05:00
qom qapi: Drop unused non-strict qobject input visitor 2018-03-02 12:14:52 -05:00
scripts qapi: rename QmpOutputVisitor to QObjectOutputVisitor 2018-02-27 08:05:33 -05:00
target i386: Don't override -cpu options on -cpu host/max 2018-03-02 14:22:45 -05:00
tcg aarch64: Change ext type to TCGType to fix warnings 2018-03-02 10:48:56 -05:00
util util/cutils: Change qemu_strtosz*() from int64_t to uint64_t 2018-03-02 08:58:55 -05:00
aarch64.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
aarch64eb.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
accel.c clean-up: removed duplicate #includes 2018-02-28 08:51:56 -05:00
arm.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
armeb.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
atomic_template.h tcg: Add atomic128 helpers 2018-02-27 21:43:48 -05:00
CODING_STYLE import 2015-08-21 15:04:50 +08:00
configure configure: remove Cygwin 2018-03-02 14:17:41 -05:00
COPYING import 2015-08-21 15:04:50 +08:00
COPYING.LIB import 2015-08-21 15:04:50 +08:00
cpu-exec-common.c tcg: Add EXCP_ATOMIC 2018-02-27 11:57:58 -05:00
cpu-exec.c cpu-exec: remove unnecessary check of cpu->exit_request 2018-03-02 11:21:35 -05:00
cpus.c tcg: handle EXCP_ATOMIC exception for system emulation 2018-03-02 09:56:43 -05:00
cputlb.c cputlb: Don't assume do_unassigned_access() never returns 2018-03-02 10:42:35 -05:00
exec.c RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
gen_all_header.sh arm64eb: add support for ARM64 big endian. 2017-04-24 23:30:01 +08:00
glib_compat.c qapi: Improve qobject input visitor error reporting 2018-03-02 12:05:53 -05:00
HACKING import 2015-08-21 15:04:50 +08:00
header_gen.py RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
ioport.c hw: remove pio_addr_t 2018-02-24 02:43:16 -05:00
LICENSE import 2015-08-21 15:04:50 +08:00
m68k.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
Makefile Makefile: Add a FORCE target 2018-02-24 17:03:51 -05:00
Makefile.objs tcg: Add atomic helpers 2018-02-27 15:57:47 -05:00
Makefile.target Move target-* CPU file into a target/ folder 2018-03-01 22:50:58 -05:00
memory.c memory: Introduce DEVICE_HOST_ENDIAN for ram device 2018-03-02 11:24:32 -05:00
memory_ldst.inc.c exec: introduce memory_ldst.inc.c 2018-03-01 09:59:34 -05:00
memory_mapping.c include/qemu/osdep.h: Don't include qapi/error.h 2018-02-21 23:08:18 -05:00
mips.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
mips64.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
mips64el.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
mipsel.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
powerpc.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
qapi-schema.json qapi: add missing colon-ending for section name 2018-03-01 09:07:10 -05:00
qemu-timer.c timer/cpus: fix some typos and update some comments 2018-02-25 23:21:57 -05:00
rules.mak rules.mak: Don't extract libs from .mo-libs in link command 2018-02-26 02:08:03 -05:00
softmmu_template.h cputlb: Remove includes from softmmu_template.h 2018-02-27 12:40:43 -05:00
sparc.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
sparc64.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00
tcg-runtime.c tcg: Add opcode for ctpop 2018-03-01 18:26:41 -05:00
translate-all.c translate-all: exit cpu_restore_state early if translating 2018-03-02 12:46:16 -05:00
translate-all.h translate-all.c: Compute L1 page table properties at runtime 2018-02-26 11:46:58 -05:00
translate-common.c exec: Clean up includes 2018-02-19 00:49:55 -05:00
unicorn_common.h qom/cpu: Add MemoryRegion property 2018-02-18 21:54:50 -05:00
VERSION import 2015-08-21 15:04:50 +08:00
vl.c tcg: add options for enabling MTTCG 2018-03-02 09:25:01 -05:00
vl.h import 2015-08-21 15:04:50 +08:00
x86_64.h RAMBlocks: qemu_ram_is_shared 2018-03-02 13:05:35 -05:00