mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2025-02-02 10:21:10 +00:00
be742759b0
When using bit-wise operations that exploit the power-of-two nature of the second argument of ROUND_UP(), we still need to ensure that the mask is as wide as the first argument (done by using a ternary to force proper arithmetic promotion). Unpatched, ROUND_UP(2ULL*1024*1024*1024*1024, 512U) produces 0, instead of the intended 2TiB, because negation of an unsigned 32-bit quantity followed by widening to 64-bits does not sign-extend the mask. Broken since its introduction in commit 292c8e50 (v1.5.0). Callers that passed the same width type to both macro parameters, or that had other code to ensure the first parameter's maximum runtime value did not exceed the second parameter's width, are unaffected, but I did not audit to see which (if any) existing clients of the macro could trigger incorrect behavior (I found the bug while adding a new use of the macro). While preparing the patch, checkpatch complained about poor spacing, so I also fixed that here and in the nearby DIV_ROUND_UP. Backports commit 33a599667a9e70588483a31286dfff8cfc27d513 from qemu |
||
|---|---|---|
| .. | ||
| atomic.h | ||
| bitmap.h | ||
| bitops.h | ||
| bswap.h | ||
| compiler.h | ||
| crc32c.h | ||
| cutils.h | ||
| fprintf-fn.h | ||
| host-utils.h | ||
| int128.h | ||
| log.h | ||
| mmap-alloc.h | ||
| module.h | ||
| osdep.h | ||
| queue.h | ||
| range.h | ||
| thread-posix.h | ||
| thread-win32.h | ||
| thread.h | ||
| timer.h | ||
| typedefs.h | ||