mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-12-24 12:15:34 +00:00
fafb3e354b
The visitor interface for mapping between QObject/QemuOpts/string and QAPI is scandalously under-documented, making changes to visitor core, individual visitors, and users of visitors difficult to coordinate. Among other questions: when is it safe to pass NULL, vs. when a string must be provided; which visitors implement which callbacks; the difference between concrete and virtual visits. Correct this by retrofitting proper contracts, and document where some of the interface warts remain (for example, we may want to modify visit_end_* to require the same 'obj' as the visit_start counterpart, so the dealloc visitor can be simplified). Later patches in this series will tackle some, but not all, of these warts. Add assertions to (partially) enforce the contract. Some of these were only made possible by recent cleanup commits. Backports commit adfb264c9ed04bfc694921b72173be8e29e90024 from qemu |
||
---|---|---|
.. | ||
qmp | ||
dealloc-visitor.h | ||
error.h | ||
qmp-input-visitor.h | ||
qmp-output-visitor.h | ||
string-input-visitor.h | ||
visitor-impl.h | ||
visitor.h |