unicorn/qemu
Emilio G. Cota fc30b3d5cf
translate-all: exit from tb_phys_invalidate if qht_remove fails
Two or more threads might race while invalidating the same TB. We currently
do not check for this at all despite taking tb_lock, which means we would
wrongly invalidate the same TB more than once. This bug has actually been
hit by users: I recently saw a report on IRC, although I have yet to see
the corresponding test case.

Fix this by using qht_remove as the synchronization point; if it fails,
that means the TB has already been invalidated, and therefore there
is nothing left to do in tb_phys_invalidate.

Note that this solution works now that we still have tb_lock, and will
continue working once we remove tb_lock.

Backports commit cc689485ee3e9dca05765326ee8fd619a6ec48f0 from qemu
2018-03-15 15:51:58 -04:00
..
accel translate-all: exit from tb_phys_invalidate if qht_remove fails 2018-03-15 15:51:58 -04:00
crypto crypto: Clean up includes 2018-02-19 00:47:40 -05:00
default-configs arm64eb: add support for ARM64 big endian. 2017-04-24 23:30:01 +08:00
docs docs: clarify memory region lifecycle 2018-02-12 15:11:21 -05:00
fpu softfloat: fix crash on int conversion of SNaN 2018-03-09 11:40:17 -05:00
hw target/arm: Make 'any' CPU just an alias for 'max' 2018-03-12 10:11:49 -04:00
include tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
qapi qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-09 11:35:11 -05:00
qobject qdict: Introduce qdict_rename_keys() 2018-03-12 10:11:48 -04:00
qom tcg: Add CPUState cflags_next_tb 2018-03-13 14:39:43 -04:00
scripts qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-09 11:35:11 -05:00
target tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
tcg tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
util osdep: introduce qemu_mprotect_rwx/none 2018-03-14 12:10:28 -04:00
aarch64.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
aarch64eb.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
accel.c clean-up: removed duplicate #includes 2018-02-28 08:51:56 -05:00
arm.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
armeb.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
CODING_STYLE import 2015-08-21 15:04:50 +08:00
configure tcg: move tcg backend files into accel/tcg/ 2018-03-13 11:48:15 -04:00
COPYING import 2015-08-21 15:04:50 +08:00
COPYING.LIB import 2015-08-21 15:04:50 +08:00
cpus.c tcg: enable multiple TCG contexts in softmmu 2018-03-14 14:32:34 -04:00
exec.c exec: Drop unnecessary code for unicorn 2018-03-12 10:11:46 -04:00
gen_all_header.sh arm64eb: add support for ARM64 big endian. 2017-04-24 23:30:01 +08:00
glib_compat.c translate-all: use a binary search tree to track TBs in TBContext 2018-03-13 16:18:29 -04:00
HACKING import 2015-08-21 15:04:50 +08:00
header_gen.py tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
ioport.c hw: remove pio_addr_t 2018-02-24 02:43:16 -05:00
LICENSE import 2015-08-21 15:04:50 +08:00
m68k.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
Makefile qapi: Don't create useless directory qapi-generated 2018-03-09 11:36:49 -05:00
Makefile.objs qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-09 11:35:11 -05:00
Makefile.target tcg: move tcg backend files into accel/tcg/ 2018-03-13 11:48:15 -04:00
memory.c memory: Share special empty FlatView 2018-03-11 22:34:28 -04:00
memory_ldst.inc.c exec: Drop unnecessary code for unicorn 2018-03-12 10:11:46 -04:00
memory_mapping.c include/qemu/osdep.h: Don't include qapi/error.h 2018-02-21 23:08:18 -05:00
mips.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
mips64.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
mips64el.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
mipsel.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
powerpc.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
qemu-timer.c timer/cpus: fix some typos and update some comments 2018-02-25 23:21:57 -05:00
rules.mak build-sys: silence make by default or V=0 2018-03-06 08:58:03 -05:00
sparc.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
sparc64.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00
unicorn_common.h tcg: enable multiple TCG contexts in softmmu 2018-03-14 14:32:34 -04:00
VERSION import 2015-08-21 15:04:50 +08:00
vl.c machine: Eliminate QEMUMachine and qemu_register_machine() 2018-03-11 15:22:25 -04:00
vl.h import 2015-08-21 15:04:50 +08:00
x86_64.h tcg: Initialize cpu_env generically 2018-03-15 15:49:19 -04:00