yuzu/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android.git synced 2024-12-27 00:55:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

yuzu/configure_gamelist: Use std::array instead of std::vector for translatable strings

Browse source 
We don't need to use an allocating container for these, given we know
the fixed amount of strings being used. This is just a waste of memory.
This commit is contained in:
Lioncash 2018-09-12 01:09:25 -04:00
parent 3a2567c97c
commit a9b953e6d4
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/yuzu/configuration/configure_gamelist.cpp
View file

@ -2,11 +2,14 @@
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
#include "core/core.h" #include <array>
#include <utility>
#include "common/common_types.h"
#include "core/settings.h" #include "core/settings.h"
#include "ui_configure_gamelist.h" #include "ui_configure_gamelist.h"
#include "ui_settings.h"
#include "yuzu/configuration/configure_gamelist.h" #include "yuzu/configuration/configure_gamelist.h"
#include "yuzu/ui_settings.h"
ConfigureGameList::ConfigureGameList(QWidget* parent) ConfigureGameList::ConfigureGameList(QWidget* parent)
: QWidget(parent), ui(new Ui::ConfigureGameList) { : QWidget(parent), ui(new Ui::ConfigureGameList) {
@ -39,11 +42,11 @@ void ConfigureGameList::setConfiguration() {
} }
void ConfigureGameList::InitializeIconSizeComboBox() { void ConfigureGameList::InitializeIconSizeComboBox() {
static const std::vector<std::pair<u32, std::string>> default_icon_sizes{ static const std::array<std::pair<u32, std::string>, 5> default_icon_sizes{{
std::make_pair(0, "None"), std::make_pair(32, "Small"), std::make_pair(0, "None"), std::make_pair(32, "Small"),
std::make_pair(64, "Standard"), std::make_pair(128, "Large"), std::make_pair(64, "Standard"), std::make_pair(128, "Large"),
std::make_pair(256, "Full Size"), std::make_pair(256, "Full Size"),
}; }};
for (const auto& size : default_icon_sizes) { for (const auto& size : default_icon_sizes) {
ui->icon_size_combobox->addItem(QString::fromStdString(size.second + " (" + ui->icon_size_combobox->addItem(QString::fromStdString(size.second + " (" +
@ -54,12 +57,12 @@ void ConfigureGameList::InitializeIconSizeComboBox() {
} }
void ConfigureGameList::InitializeRowComboBoxes() { void ConfigureGameList::InitializeRowComboBoxes() {
static const std::vector<std::string> row_text_names{ static const std::array<std::string, 4> row_text_names{{
"Filename", "Filename",
"Filetype", "Filetype",
"Title ID", "Title ID",
"Title Name", "Title Name",
}; }};
for (size_t i = 0; i < row_text_names.size(); ++i) { for (size_t i = 0; i < row_text_names.size(); ++i) {
ui->row_1_text_combobox->addItem(QString::fromStdString(row_text_names[i]), ui->row_1_text_combobox->addItem(QString::fromStdString(row_text_names[i]),