Merge pull request #1939 from ONLYOFFICE/feature/fix-bugs

Feature/fix bugs
This commit is contained in:
maxkadushkin 2022-09-05 17:33:02 +03:00 committed by GitHub
commit 904e8ea272
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 49 additions and 34 deletions

View file

@ -109,9 +109,13 @@ class MainPage extends Component {
render() { render() {
const { t } = this.props; const { t } = this.props;
const appOptions = this.props.storeAppOptions; const appOptions = this.props.storeAppOptions;
const storeDocumentInfo = this.props.storeDocumentInfo;
const docExt = storeDocumentInfo.dataDoc ? storeDocumentInfo.dataDoc.fileType : '';
const isAvailableExt = docExt && docExt !== 'djvu' && docExt !== 'pdf' && docExt !== 'xps';
const storeToolbarSettings = this.props.storeToolbarSettings; const storeToolbarSettings = this.props.storeToolbarSettings;
const isDisconnected = this.props.users.isDisconnected; const isDisconnected = this.props.users.isDisconnected;
const isViewer = appOptions.isViewer; const isViewer = appOptions.isViewer;
const isEdit = appOptions.isEdit;
const isMobileView = appOptions.isMobileView; const isMobileView = appOptions.isMobileView;
const disabledControls = storeToolbarSettings.disabledControls; const disabledControls = storeToolbarSettings.disabledControls;
const disabledSettings = storeToolbarSettings.disabledSettings; const disabledSettings = storeToolbarSettings.disabledSettings;
@ -214,7 +218,7 @@ class MainPage extends Component {
text={isMobileView ? t("Toolbar.textSwitchedMobileView") : t("Toolbar.textSwitchedStandardView")}/> text={isMobileView ? t("Toolbar.textSwitchedMobileView") : t("Toolbar.textSwitchedStandardView")}/>
</CSSTransition> </CSSTransition>
} }
{isViewer && !disabledSettings && !disabledControls && !isDisconnected && {isViewer && !disabledSettings && !disabledControls && !isDisconnected && isAvailableExt && isEdit &&
<Fab position="right-bottom" slot="fixed" onClick={() => this.turnOffViewerMode()}> <Fab position="right-bottom" slot="fixed" onClick={() => this.turnOffViewerMode()}>
<Icon icon="icon-edit-mode"/> <Icon icon="icon-edit-mode"/>
</Fab> </Fab>
@ -226,4 +230,4 @@ class MainPage extends Component {
} }
} }
export default withTranslation()(inject("storeAppOptions", "storeToolbarSettings", "users")(observer(MainPage))); export default withTranslation()(inject("storeAppOptions", "storeToolbarSettings", "users", "storeDocumentInfo")(observer(MainPage)));

View file

@ -46,13 +46,11 @@ const ToolbarView = props => {
onUndoClick: props.onUndo, onUndoClick: props.onUndo,
onRedoClick: props.onRedo onRedoClick: props.onRedo
})} })}
{(isViewer || !Device.phone) && isAvailableExt && <Link className={props.disabledControls ? 'disabled' : ''} icon={isMobileView ? 'icon-standard-view' : 'icon-mobile-view'} href={false} onClick={async e => { {(isViewer || !Device.phone) && isAvailableExt && !props.disabledControls && <Link icon={isMobileView ? 'icon-standard-view' : 'icon-mobile-view'} href={false} onClick={async e => {
e.target.closest('.link').classList.add('disabled');
await props.changeMobileView(); await props.changeMobileView();
await props.openOptions('snackbar'); await props.openOptions('snackbar');
setTimeout(() => { setTimeout(() => {
props.closeOptions('snackbar'); props.closeOptions('snackbar');
e.target.closest('.link').classList.remove('disabled');
}, 1500); }, 1500);
}}></Link>} }}></Link>}
{(props.showEditDocument && !isViewer) && {(props.showEditDocument && !isViewer) &&

View file

@ -500,6 +500,11 @@ const EditText = props => {
const isAndroid = Device.android; const isAndroid = Device.android;
const { t } = useTranslation(); const { t } = useTranslation();
const storeTextSettings = props.storeTextSettings; const storeTextSettings = props.storeTextSettings;
const storeFocusObjects = props.storeFocusObjects;
const shapeObject = storeFocusObjects.shapeObject;
const shapePr = shapeObject.get_ShapeProperties();
const inSmartArt = shapePr && shapePr.asc_getFromSmartArt();
const inSmartArtInternal = shapePr && shapePr.asc_getFromSmartArtInternal();
const fontName = storeTextSettings.fontName || t('Edit.textFonts'); const fontName = storeTextSettings.fontName || t('Edit.textFonts');
const fontSize = storeTextSettings.fontSize; const fontSize = storeTextSettings.fontSize;
const fontColor = storeTextSettings.textColor; const fontColor = storeTextSettings.textColor;
@ -589,16 +594,23 @@ const EditText = props => {
</a> </a>
</Row> </Row>
</ListItem> </ListItem>
{!inSmartArtInternal &&
<ListItem className='buttons'> <ListItem className='buttons'>
<Row> <Row>
<a className='button item-link' onClick={() => {props.onParagraphMove(true)}}> <a className='button item-link' onClick={() => {
props.onParagraphMove(true)
}}>
<Icon slot="media" icon="icon-de-indent"></Icon> <Icon slot="media" icon="icon-de-indent"></Icon>
</a> </a>
<a className='button item-link' onClick={() => {props.onParagraphMove(false)}}> <a className='button item-link' onClick={() => {
props.onParagraphMove(false)
}}>
<Icon slot="media" icon="icon-in-indent"></Icon> <Icon slot="media" icon="icon-in-indent"></Icon>
</a> </a>
</Row> </Row>
</ListItem> </ListItem>
}
{!inSmartArt && !inSmartArtInternal &&
<ListItem title={t('Edit.textBulletsAndNumbers')} link='/edit-bullets-and-numbers/' routeProps={{ <ListItem title={t('Edit.textBulletsAndNumbers')} link='/edit-bullets-and-numbers/' routeProps={{
onBullet: props.onBullet, onBullet: props.onBullet,
onNumber: props.onNumber, onNumber: props.onNumber,
@ -608,6 +620,7 @@ const EditText = props => {
<div className="preview">{previewList}</div> <div className="preview">{previewList}</div>
{!isAndroid && <Icon slot="media" icon="icon-bullets"></Icon>} {!isAndroid && <Icon slot="media" icon="icon-bullets"></Icon>}
</ListItem> </ListItem>
}
<ListItem title={t("Edit.textLineSpacing")} link='/edit-text-line-spacing/' routeProps={{ <ListItem title={t("Edit.textLineSpacing")} link='/edit-text-line-spacing/' routeProps={{
onLineSpacing: props.onLineSpacing onLineSpacing: props.onLineSpacing
}}> }}>

View file

@ -98,12 +98,12 @@ const PageApplicationSettings = props => {
</Toggle> </Toggle>
</ListItem> </ListItem>
</List> </List>
{!isViewer && {/*{!isViewer &&*/}
<List mediaList> {/* <List mediaList>*/}
<ListItem title={t('Settings.textDirection')} link="/direction/" {/* <ListItem title={t('Settings.textDirection')} link="/direction/"*/}
routeProps={{changeDirection: props.changeDirection}}></ListItem> {/* routeProps={{changeDirection: props.changeDirection}}></ListItem>*/}
</List> {/* </List>*/}
} {/*}*/}
{_isShowMacros && {_isShowMacros &&
<List mediaList> <List mediaList>
<ListItem title={_t.textMacrosSettings} link="/macros-settings/" routeProps={{ <ListItem title={_t.textMacrosSettings} link="/macros-settings/" routeProps={{

View file

@ -52,7 +52,7 @@ const PageApplicationSettings = props => {
</Toggle> </Toggle>
</ListItem> </ListItem>
</List> </List>
<RTLSetting /> {/*<RTLSetting />*/}
</Fragment> </Fragment>
} }
{/* {_isShowMacros && */} {/* {_isShowMacros && */}

View file

@ -98,9 +98,9 @@ const PageApplicationSettings = props => {
</ListItem> </ListItem>
</List> </List>
<List mediaList> {/*<List mediaList>*/}
<ListItem title={t("View.Settings.textDirection")} link="/direction/" routeProps={{changeDirection: props.changeDirection}}></ListItem> {/* <ListItem title={t("View.Settings.textDirection")} link="/direction/" routeProps={{changeDirection: props.changeDirection}}></ListItem>*/}
</List> {/*</List>*/}
{/* } */} {/* } */}
{/* {_isShowMacros && */} {/* {_isShowMacros && */}
<List> <List>